Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AST] Implement CONCAT_WS function In AST #965

Merged
merged 10 commits into from
Oct 29, 2022
Merged

[AST] Implement CONCAT_WS function In AST #965

merged 10 commits into from
Oct 29, 2022

Conversation

seonghun-dev
Copy link
Contributor

  • Add concat_ws function in ast

@seonghun-dev seonghun-dev marked this pull request as ready for review October 23, 2022 08:10
@seonghun-dev seonghun-dev changed the title [Draft] [AST] Implement CONCAT_WS function In AST [AST] Implement CONCAT_WS function In AST Oct 23, 2022
@coveralls
Copy link

coveralls commented Oct 23, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3349748896

  • 159 of 159 (100.0%) changed or added relevant lines in 7 files are covered.
  • 44 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.06%) to 97.866%
Files with Coverage Reduction New Missed Lines %
core/src/executor/execute.rs 1 94.98%
core/src/executor/fetch.rs 1 97.6%
core/src/translate/query.rs 1 98.95%
storages/sled-storage/src/index_mut.rs 2 98.58%
core/src/executor/alter/table.rs 7 94.35%
storages/sled-storage/src/alter_table.rs 10 97.08%
cli/src/print.rs 22 94.67%
Totals Coverage Status
Change from base Build 3303918887: 0.06%
Covered Lines: 38433
Relevant Lines: 39271
💛 - Coveralls

@seonghun-dev
Copy link
Contributor Author

Same coverage Issue in #899

@panarch panarch added the enhancement New feature or request label Oct 26, 2022
panarch
panarch requested changes Oct 26, 2022
View reviewed changes
core/src/executor/evaluate/function.rs Outdated Show resolved Hide resolved
core/src/plan/expr/function.rs Outdated Show resolved Hide resolved
@seonghun-dev seonghun-dev requested review from panarch and removed request for ever0de and devgony October 26, 2022 04:38
@panarch panarch self-requested a review October 29, 2022 02:08
@panarch panarch self-requested a review October 29, 2022 03:39
panarch
panarch approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks nice! Thanks a lot 👍 👍

@panarch panarch merged commit d2a07dc into gluesql:main Oct 29, 2022
@panarch panarch mentioned this pull request Oct 29, 2022
Closed
@seonghun-dev seonghun-dev deleted the concat_ws branch October 29, 2022 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

Assignees

@seonghun-dev seonghun-dev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seonghun-dev @coveralls @panarch