Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Cow from Evaluated::Value #963

Merged
merged 1 commit into from
Oct 22, 2022
Merged

Remove Cow from Evaluated::Value #963

merged 1 commit into from
Oct 22, 2022

Conversation

zmrdltl
Copy link
Collaborator

@zmrdltl zmrdltl commented Oct 22, 2022 •
edited
Loading

Description

pub enum Evaluated<'a> {
    Literal(Literal<'a>),
    Value(Cow<'a, Value>),
}

to

pub enum Evaluated<'a> {
    Literal(Literal<'a>),
    Value(Value),
}

enum Evaluated does not need to use Cow for enum Value

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3302589739

  • 17 of 19 (89.47%) changed or added relevant lines in 2 files are covered.
  • 35 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.06%) to 97.816%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/executor/evaluate/evaluated.rs 16 18 88.89%
Files with Coverage Reduction New Missed Lines %
test-suite/src/tester/mod.rs 1 87.5%
core/src/translate/query.rs 2 98.93%
core/src/executor/aggregate/mod.rs 32 82.89%
Totals Coverage Status
Change from base Build 3302307127: -0.06%
Covered Lines: 38253
Relevant Lines: 39107
💛 - Coveralls

@panarch panarch added the improvement Improvements for existing features label Oct 22, 2022
panarch
panarch approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this nice improvement :D
All looks good 👍

@panarch panarch merged commit e0d645c into gluesql:main Oct 22, 2022
@zmrdltl zmrdltl deleted the feature-evaluate branch October 22, 2022 08:44
@panarch panarch changed the title Remove unneccesary syntax in enum Evaluated Remove Cow from Evaluated::Value Oct 22, 2022
devgony pushed a commit to devgony/gluesql that referenced this pull request Oct 29, 2022
@zmrdltl @devgony
Remove Cow from Evaluated::Value (gluesql#963)
d52f307 
enum Evaluated does not need to use Cow for enum Value

from:
pub enum Evaluated<'a> {
    Literal(Literal<'a>),
    Value(Cow<'a, Value>),
}

to:
pub enum Evaluated<'a> {
    Literal(Literal<'a>),
    Value(Value),
}
@panarch panarch mentioned this pull request Apr 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@devgony devgony Awaiting requested review from devgony

@ever0de ever0de Awaiting requested review from ever0de

Assignees

@zmrdltl zmrdltl

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zmrdltl @coveralls @panarch