Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AST builder ExprNode to contain borrowed values, #961

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Update AST builder ExprNode to contain borrowed values, #961

merged 2 commits into from
Oct 20, 2022

Conversation

panarch
Copy link
Member

@panarch panarch commented Oct 20, 2022

Change ExprNode to ExprNode<'a>.
Update ExprNode::Expr to contain Cow<..>.
Apply corresponding changes - mainly updating select nodes to have lifetimes

This is the beginning of updating the AST builder to accept borrowed values.

@panarch
Update AST builder ExprNode to contain borrowed values,
29dd8af 
Change ExprNode to ExprNode<'a>.
Update ExprNode::Expr to contain Cow<..>.
Apply corresponding changes - mainly updating select nodes to have lifetimes
@panarch panarch added the improvement Improvements for existing features label Oct 20, 2022
@panarch panarch requested review from ever0de and devgony October 20, 2022 05:36
@panarch panarch self-assigned this Oct 20, 2022
@coveralls
Copy link

coveralls commented Oct 20, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3287130960

  • 350 of 350 (100.0%) changed or added relevant lines in 33 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 97.805%
Totals Coverage Status
Change from base Build 3279870115: 0.008%
Covered Lines: 38236
Relevant Lines: 39094
💛 - Coveralls

ever0de
ever0de approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@panarch panarch merged commit 3557d48 into main Oct 20, 2022
@panarch panarch deleted the ast-builder-nodes-to-accept-borrowed-values branch October 20, 2022 13:58
devgony pushed a commit to devgony/gluesql that referenced this pull request Oct 29, 2022
@panarch @devgony
Update AST builder ExprNode to contain borrowed values, (gluesql#961)
6b486eb 
Change ExprNode to ExprNode<'a>.
Update ExprNode::Expr to contain Cow<..>.
Apply corresponding changes - mainly updating select nodes to have lifetimes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ever0de ever0de ever0de approved these changes

@devgony devgony Awaiting requested review from devgony

Assignees

@panarch panarch

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panarch @coveralls @ever0de