Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use decl macro to simplify codes in parser_sql module #937

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Use decl macro to simplify codes in parser_sql module #937

merged 1 commit into from
Oct 14, 2022

Conversation

sa1
Copy link
Contributor

@sa1 sa1 commented Oct 13, 2022

Fixes #909

@coveralls
Copy link

coveralls commented Oct 13, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3250731032

  • 19 of 45 (42.22%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 97.894%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/parse_sql.rs 17 43 39.53%
Totals Coverage Status
Change from base Build 3249269846: -0.05%
Covered Lines: 38078
Relevant Lines: 38897
💛 - Coveralls

@ever0de ever0de added the improvement Improvements for existing features label Oct 14, 2022
ever0de
ever0de reviewed Oct 14, 2022
View reviewed changes
Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome

I left my little comments. This is a formatting level opinion, so please leave any additional comments.

core/src/parse_sql.rs Outdated Show resolved Hide resolved
core/src/parse_sql.rs Outdated Show resolved Hide resolved
core/src/parse_sql.rs Outdated Show resolved Hide resolved
ever0de
ever0de approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Thank you for your efforts

@sa1
Copy link
Contributor Author

sa1 commented Oct 14, 2022

Thanks, I implemented those changes.

panarch
panarch approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite much better! Thanks a lot 👍

@panarch panarch merged commit 6449504 into gluesql:main Oct 14, 2022
@panarch panarch changed the title Use macro to generate SQL parsers Use decl macro to simplify codes in parser_sql module Oct 14, 2022
@sa1 sa1 deleted the parsemacro branch October 14, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ever0de ever0de ever0de approved these changes

@panarch panarch panarch approved these changes

@devgony devgony Awaiting requested review from devgony

Assignees

@sa1 sa1

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Macro] Implement the parse_* fn generation macro
4 participants
@sa1 @coveralls @panarch @ever0de