Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Option which wraps Row in FilterContext, #933

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Remove Option which wraps Row in FilterContext, #933

merged 1 commit into from
Oct 13, 2022

Conversation

panarch
Copy link
Member

@panarch panarch commented Oct 13, 2022

There was no use case of Content::Some { row: None, .. } but Option type was unnecessarily being used. Remove Option from Content::Some { row } in FilterContext

@panarch
Remove Option which wraps Row in FilterContext,
ca085b2 
There was no use case of Content::Some { row: None, .. } but Option type was unnecessarily being used.
Remove Option from Content::Some { row } in FilterContext
@panarch panarch requested review from ever0de and devgony October 13, 2022 12:37
@panarch panarch self-assigned this Oct 13, 2022
ever0de
ever0de approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch 👍

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3242415320

  • 7 of 7 (100.0%) changed or added relevant lines in 4 files are covered.
  • 34 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 97.877%
Files with Coverage Reduction New Missed Lines %
core/src/executor/aggregate/mod.rs 16 89.74%
test-suite/src/tester/mod.rs 18 88.16%
Totals Coverage Status
Change from base Build 3242396698: -0.07%
Covered Lines: 37851
Relevant Lines: 38672
💛 - Coveralls

@panarch panarch merged commit 2094e56 into main Oct 13, 2022
@panarch panarch deleted the remove-option-from-filtercontext-row branch October 13, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devgony devgony devgony approved these changes

@ever0de ever0de ever0de approved these changes

Assignees

@panarch panarch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panarch @coveralls @ever0de @devgony