Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] add data type u16 #844

Merged
merged 47 commits into from
Oct 29, 2022
Merged

[Data] add data type u16 #844

merged 47 commits into from
Oct 29, 2022

Conversation

ChobobDev
Copy link
Contributor

@ChobobDev ChobobDev commented Sep 14, 2022 •
edited
Loading

Background

from #623

ref
add data type u8

Description

  • When calculating arithmetic operations on u16 and i16, both are converted to i64 and calculated.
  • For the remaining types, cast to the larger type.

Rules

  1. cast right-hand element into left-hand element type in case of arithmetics between INTEGER types
  2. in case of INTEGER * FLOAT convert to FLOAT
  3. in case of INTEGER * DECIMAL convert to DECIMAL
  4. in case of FLOAT * DECIMAL convert to FLOAT

@coveralls
Copy link

coveralls commented Sep 14, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3350333081

  • 833 of 837 (99.52%) changed or added relevant lines in 20 files are covered.
  • 23 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.04%) to 97.937%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/data/key.rs 15 16 93.75%
core/src/data/value/convert.rs 95 96 98.96%
core/src/data/value/mod.rs 64 66 96.97%
Files with Coverage Reduction New Missed Lines %
core/src/executor/context/filter_context.rs 4 93.44%
test-suite/src/tester/mod.rs 19 87.5%
Totals Coverage Status
Change from base Build 3349913767: 0.04%
Covered Lines: 39269
Relevant Lines: 40096
💛 - Coveralls

@ever0de ever0de added the enhancement New feature or request label Sep 15, 2022
@ever0de ever0de mentioned this pull request Sep 15, 2022
Closed
13 tasks
@ChobobDev
feat: add U16 to binary operator
8de937a
@ChobobDev
Merge branch 'main' into feature/data_type_u16
66133c4
@ChobobDev
feat: implement new data type u16
f539bc3
@ChobobDev
Merge branch 'main' into feature/data_type_u16
7ffd46a
@ChobobDev
Merge branch 'main' into feature/data_type_u16
678014f
@ChobobDev
feat: add u16 rules
58c5ad6
@ChobobDev
fix: fix misleading typos
f81c788
@ChobobDev
test: improve line coverage
c6b550d
@ChobobDev
test: remove misleading test cases
3414b46
@ChobobDev
test: add new test cases to improve line coverage
b94f9a8
@ChobobDev
fix: add ommited datatype
68ff230
@ChobobDev
test: improve line coverage of convert.rs
af4a466
@ChobobDev
test: improve line coverage of key.rs
c7249c8
@ChobobDev
test: improve line coverage in mod.rs
e375b4d
@ChobobDev
test: added omitted test cases of decimal.rs
416faea
@ChobobDev
test: improve line coverage of primitive.rs
4eb6675
@ChobobDev
test : improve line coverage of i8.rs
4e9595f
@ChobobDev
test: add omitted test case
7efaf6a
@ChobobDev
test: improve line coverage of u8.rs
3791804
@ChobobDev
test: remove misleading test cases
8f38ebe
@ChobobDev ChobobDev marked this pull request as ready for review September 17, 2022 19:18
@ChobobDev ChobobDev mentioned this pull request Sep 30, 2022
Closed
@ChobobDev ChobobDev force-pushed the feature/data_type_u16 branch from 529ed2c to 78bacee Compare October 14, 2022 03:43
panarch
panarch approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍 👍
All looks nice!
Thanks for the contribution! New numeric type has come :D

@panarch panarch merged commit 823e8e8 into gluesql:main Oct 29, 2022
@ChobobDev ChobobDev deleted the feature/data_type_u16 branch November 5, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devgony devgony devgony left review comments

@panarch panarch panarch approved these changes

@ever0de ever0de Awaiting requested review from ever0de

@24seconds 24seconds Awaiting requested review from 24seconds

@MRGRAVITY817 MRGRAVITY817 Awaiting requested review from MRGRAVITY817

Assignees

@ChobobDev ChobobDev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChobobDev @coveralls @panarch @devgony @ever0de