Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AST Builder] Update FunctionNode structure #723

Merged
merged 1 commit into from
Aug 6, 2022
Merged

[AST Builder] Update FunctionNode structure #723

merged 1 commit into from
Aug 6, 2022

Conversation

zmrdltl
Copy link
Collaborator

@zmrdltl zmrdltl commented Aug 6, 2022 •
edited
Loading

Description

Fixed structure for uniform cast in ast_builder.
Instead of being converted to Expr directly at each node, conversion is performed to the correct enum type in the intermediate stage.

@zmrdltl zmrdltl changed the title Update FunctionNode structure [AST Builder] Update FunctionNode structure Aug 6, 2022
@zmrdltl zmrdltl force-pushed the feature-ast_builder branch from 0643c98 to 3c794ea Compare August 6, 2022 14:01
@panarch panarch added the improvement Improvements for existing features label Aug 6, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2809161722

  • 21 of 21 (100.0%) changed or added relevant lines in 2 files are covered.
  • 36 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 97.894%
Files with Coverage Reduction New Missed Lines %
core/src/data/value/binary_op/i64.rs 36 95.8%
Totals Coverage Status
Change from base Build 2808741849: -0.003%
Covered Lines: 29326
Relevant Lines: 29957
💛 - Coveralls

panarch
panarch approved these changes Aug 6, 2022
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks a lot for the meaningful improvement changes :)

@panarch panarch merged commit 6dde752 into gluesql:main Aug 6, 2022
@zmrdltl zmrdltl deleted the feature-ast_builder branch August 6, 2022 14:25
ever0de pushed a commit to ever0de/gluesql that referenced this pull request Sep 11, 2022
@zmrdltl @ever0de
Update AST builder FunctionNode convert code structure (gluesql#723)
6c72258 
Change from
`impl TryFrom<FunctionNode> for Expr`
to
`impl TryFrom<FunctionNode> for Function`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@24seconds 24seconds Awaiting requested review from 24seconds

@ever0de ever0de Awaiting requested review from ever0de

Assignees

@zmrdltl zmrdltl

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zmrdltl @coveralls @panarch