Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Debug macro from the generic requirements for key #486

Merged
merged 1 commit into from
Feb 20, 2022
Merged

Remove Debug macro from the generic requirements for key #486

merged 1 commit into from
Feb 20, 2022

Conversation

ever0de
Copy link
Member

@ever0de ever0de commented Feb 20, 2022

We don't need to require the Debug macro for the Generic type T we use as Key.
because the Debug macro is not used internally.

@ever0de ever0de requested a review from panarch February 20, 2022 13:51
@ever0de ever0de self-assigned this Feb 20, 2022
@ever0de ever0de added the improvement Improvements for existing features label Feb 20, 2022
@ever0de ever0de force-pushed the remove-debug-from-the-generic-requirements-for-key-use branch from 0009969 to 58cf6ba Compare February 20, 2022 14:20
@ever0de ever0de force-pushed the remove-debug-from-the-generic-requirements-for-key-use branch from 58cf6ba to fdbcdfa Compare February 20, 2022 14:21
@ever0de
Copy link
Member Author

ever0de commented Feb 20, 2022

Rebase upstream main...

@codecov-commenter
Copy link

Codecov Report

Merging #486 (fdbcdfa) into main (a1a7279) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #486   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         160      160           
  Lines        9393     9393           
=======================================
  Hits         8607     8607           
  Misses        786      786
Impacted Files Coverage Δ
core/src/executor/aggregate/mod.rs 76.59% <ø> (ø)
core/src/executor/select/blend.rs 92.85% <ø> (ø)
core/src/executor/sort.rs 76.00% <ø> (ø)
core/src/executor/update.rs 77.35% <ø> (ø)
core/src/glue.rs 100.00% <ø> (ø)
storages/sled-storage/src/snapshot.rs 88.70% <ø> (ø)
core/src/executor/alter/alter_table.rs 67.85% <100.00%> (ø)
core/src/executor/alter/index.rs 87.50% <100.00%> (ø)
core/src/executor/alter/table.rs 81.66% <100.00%> (ø)
core/src/executor/evaluate/mod.rs 80.99% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a7279...fdbcdfa. Read the comment docs.

panarch
panarch approved these changes Feb 20, 2022
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks so much

@panarch panarch merged commit afa638b into gluesql:main Feb 20, 2022
ever0de added a commit to ever0de/gluesql that referenced this pull request Mar 6, 2022
@ever0de
Remove Debug macro from the generic requirements for key in store t…
a3ce979 
…raits (gluesql#486)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

Assignees

@ever0de ever0de

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ever0de @codecov-commenter @panarch