Bump up sqlparser crate version from 0.11 to 0.13
#479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panarch
reviewed
Feb 3, 2022
core/src/translate/mod.rs
Outdated
| return Err(TranslateError::JoinOnUpdateNotSupported.into()); | ||
| } | ||
| match &table.relation { | ||
| TableFactor::Table { name, .. } => Ok(ObjectName(translate_idents(&name.0))), |
There was a problem hiding this comment.
You can use translate_object_name here
panarch
reviewed
Feb 3, 2022
core/src/translate/mod.rs
Outdated
| } | ||
| match &table.relation { | ||
| TableFactor::Table { name, .. } => Ok(ObjectName(translate_idents(&name.0))), | ||
| _ => Err(TranslateError::JoinOnUpdateNotSupported.into()), |
There was a problem hiding this comment.
It looks that this could be not directly related to JOIN.
Let's add a new error with UnsupportedTableFactor(String) and have a corresponding test case for this.
Codecov Report
@@ Coverage Diff @@
## main #479 +/- ##
==========================================
+ Coverage 91.59% 91.61% +0.02%
==========================================
Files 160 160
Lines 9366 9379 +13
==========================================
+ Hits 8579 8593 +14
+ Misses 787 786 -1
Continue to review full report at Codecov.
|
panarch
approved these changes
Feb 5, 2022
ever0de
pushed a commit
to ever0de/gluesql
that referenced
this pull request
Feb 20, 2022
Most of the changes are in SqlStatement::Update part, - table field is now TableWithJoin type, so I had to take relation field out of it and converted into ObjectName. - SqlAssignment's id is now Vec<Ident> type, so I took only the first element's value.
ever0de
pushed a commit
to ever0de/gluesql
that referenced
this pull request
Mar 6, 2022
Most of the changes are in SqlStatement::Update part, - table field is now TableWithJoin type, so I had to take relation field out of it and converted into ObjectName. - SqlAssignment's id is now Vec<Ident> type, so I took only the first element's value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump up
sqlparserversion.Changes made
Most of the changes are in
SqlStatement::Updatepart,tablefield is nowTableWithJointype, so I had to takerelationfield out of it and converted intoObjectName.SqlAssignment'sidis nowVec<Ident>type, so I took only the first element's value.TODO's after implementing
JoinJoinOnUpdateNotSupportederror.