Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce try_self! and try_into! macro uses, #302

Merged
merged 2 commits into from
Aug 20, 2021
Merged

Conversation

panarch
Copy link
Member

@panarch panarch commented Aug 20, 2021

Add TrySelf trait to result module.
Replace all try_self! macros and some try_into! macro to TrySelf trait.

Add TrySelf trait to result module.
Replace all try_self! macros and some try_into! macro to TrySelf trait.
@panarch panarch self-assigned this Aug 20, 2021
Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so neat.
LGTM!

@ever0de
Copy link
Member

ever0de commented Aug 20, 2021

Thank you for correcting comment!

We talked on the discord

  • No 'static lifetime required by TrySelf

Sorry, something went wrong.

@panarch
Copy link
Member Author

panarch commented Aug 20, 2021

@ever0de Thanks a lot for the comment!

@panarch panarch requested a review from ever0de August 20, 2021 13:23
@panarch panarch merged commit 1d55080 into main Aug 20, 2021
@panarch panarch deleted the reduce-try-macro-uses branch August 20, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants