Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add datetime conversion test cases for ast_builder #1187

Merged
merged 4 commits into from
May 13, 2023
Merged

Add datetime conversion test cases for ast_builder #1187

merged 4 commits into from
May 13, 2023

Conversation

heewoneha
Copy link
Contributor

Goal

  • Add test cases (Conversion of Date & Time)

Todo

  • Date test case
  • Time test case
  • Timestamp test case

@devgony devgony requested review from panarch and devgony May 13, 2023 11:36
@devgony devgony added the improvement Improvements for existing features label May 13, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4966881170

  • 64 of 69 (92.75%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 98.914%
Changes Missing Coverage Covered Lines Changed/Added Lines %
test-suite/src/ast_builder/function/datetime/conversion.rs 64 69 92.75%
Files with Coverage Reduction New Missed Lines %
core/src/ast/mod.rs 1 99.83%
Totals Coverage Status
Change from base Build 4966847696: -0.03%
Covered Lines: 43355
Relevant Lines: 43831
💛 - Coveralls

panarch
panarch approved these changes May 13, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all nice! Thanks a lot 👍 👍

@panarch panarch merged commit b984ab0 into gluesql:main May 13, 2023
sooyeonyim-t pushed a commit to sooyeonyim-t/gluesql that referenced this pull request May 14, 2023
@heewoneha @sooyeonyim-t
Add datetime conversion test cases for ast_builder (gluesql#1187)
a5b1344
@heewoneha heewoneha deleted the ast_builder_function_datetime_conversion branch May 15, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@devgony devgony Awaiting requested review from devgony

Assignees

@heewoneha heewoneha

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heewoneha @coveralls @panarch @devgony