Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Rc in validate.rs #1106

Merged
merged 1 commit into from
Feb 18, 2023
Merged

Remove Rc in validate.rs #1106

merged 1 commit into from
Feb 18, 2023

Conversation

ever0de
Copy link
Member

@ever0de ever0de commented Feb 18, 2023

No description provided.

@ever0de ever0de added the improvement Improvements for existing features label Feb 18, 2023
@ever0de ever0de requested a review from panarch February 18, 2023 15:49
@ever0de ever0de self-assigned this Feb 18, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4211909642

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • 35 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.09%) to 98.733%
Files with Coverage Reduction New Missed Lines %
core/src/data/interval/mod.rs 1 99.48%
core/src/executor/validate.rs 1 99.24%
core/src/executor/aggregate/mod.rs 33 82.99%
Totals Coverage Status
Change from base Build 4211260088: -0.09%
Covered Lines: 38483
Relevant Lines: 38977
💛 - Coveralls

panarch
panarch approved these changes Feb 18, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's getting better and better over time!
Looks nice 👍
Thanks a lot

@panarch panarch merged commit 4908773 into gluesql:main Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

Assignees

@ever0de ever0de

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ever0de @coveralls @panarch