Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace dyn object to generic #1075

Merged
merged 1 commit into from
Jan 29, 2023
Merged

Replace dyn object to generic #1075

merged 1 commit into from
Jan 29, 2023

Conversation

ever0de
Copy link
Member

@ever0de ever0de commented Jan 29, 2023

No description provided.

@ever0de ever0de added the improvement Improvements for existing features label Jan 29, 2023
@ever0de ever0de requested review from panarch and devgony January 29, 2023 07:16
@ever0de ever0de self-assigned this Jan 29, 2023
@ever0de ever0de force-pushed the replace-dyn-object-to-generic branch from 4315188 to ecafc00 Compare January 29, 2023 07:19
@ever0de ever0de marked this pull request as ready for review January 29, 2023 07:41
@coveralls
Copy link

coveralls commented Jan 29, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4035683838

  • 66 of 66 (100.0%) changed or added relevant lines in 12 files are covered.
  • 22 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 98.512%
Files with Coverage Reduction New Missed Lines %
core/src/executor/aggregate/mod.rs 7 83.33%
core/src/executor/evaluate/stateless.rs 15 94.09%
Totals Coverage Status
Change from base Build 4035576483: -0.05%
Covered Lines: 37947
Relevant Lines: 38520
💛 - Coveralls

panarch
panarch approved these changes Jan 29, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, nice improvement! Thanks a lot! All looks nice

@panarch panarch merged commit 52ecba0 into gluesql:main Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@devgony devgony Awaiting requested review from devgony

Assignees

@ever0de ever0de

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ever0de @coveralls @panarch