Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove data::RowError, #1040

Merged
merged 1 commit into from
Dec 10, 2022
Merged

Remove data::RowError, #1040

merged 1 commit into from
Dec 10, 2022

Conversation

panarch
Copy link
Member

@panarch panarch commented Dec 9, 2022 •
edited
Loading

  • Move RowError::NumberOfValuesDifferent to SelectError.
  • Remove RowError::ConflictOnEmptyRow by making evaluate module to handle this.
    This ConflictOnEmptyRow error is now just hidden by evaluate and that might be not an ideal solution.
    We need NonEmptyVec struct for this. (Vec<SelectItem> to NonEmptyVec<SelectItem> for projection)

@panarch
Remove data::RowError,
7af722a 
Move RowError::NumberOfValuesDifferent to SelectError.
Remove RowError::ConflictOnEmptyRow by making evaluate module to handle this.
This ConflictOnEmptyRow error is now just hidden by evaluate and that might be not ideal solution.
We need NonEmptyVec struct for this. (Vec<SelectItem> to NonEmptyVec<SelectItem> for projection)
@panarch panarch requested review from ever0de and devgony December 9, 2022 06:34
@panarch panarch self-assigned this Dec 9, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3655086222

  • 15 of 15 (100.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+4.0e**-05%**) to 98.555%
Files with Coverage Reduction New Missed Lines %
core/src/result.rs 1 69.77%
Totals Coverage Status
Change from base Build 3630622723: 4.0e-05%
Covered Lines: 37317
Relevant Lines: 37864
💛 - Coveralls

ever0de
ever0de approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@panarch panarch merged commit 9ddfaa9 into main Dec 10, 2022
@panarch panarch deleted the remove-rowerror branch December 10, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ever0de ever0de ever0de approved these changes

@devgony devgony Awaiting requested review from devgony

Assignees

@panarch panarch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panarch @coveralls @ever0de