Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UINT32, UINT64 and UINT128 data types #1019

Merged
merged 67 commits into from
Apr 6, 2023
Merged

Add UINT32, UINT64 and UINT128 data types #1019

merged 67 commits into from
Apr 6, 2023

Conversation

ChobobDev
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Nov 26, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 4630325363

  • 1297 of 1309 (99.08%) changed or added relevant lines in 15 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 98.918%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/data/value/convert.rs 310 313 99.04%
core/src/data/value/literal.rs 67 76 88.16%
Files with Coverage Reduction New Missed Lines %
core/src/data/value/mod.rs 1 99.16%
Totals Coverage Status
Change from base Build 4596000261: 0.1%
Covered Lines: 41402
Relevant Lines: 41855
💛 - Coveralls

@ever0de ever0de mentioned this pull request Dec 1, 2022
Closed
13 tasks
@ChobobDev ChobobDev mentioned this pull request Apr 2, 2023
Closed
@ChobobDev ChobobDev force-pushed the feature/uint_data_type branch from e194297 to 9c62b2c Compare April 4, 2023 11:40
@ChobobDev
Copy link
Contributor Author

I think I am ready for the review :0

panarch
panarch requested changes Apr 5, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd really appreciate the work you've done. Awesome!
Before the merge, could you add a few more tests to fill the remaining coverage?

image
#1019 (comment)

You can only care "New" lines

core/src/data/value/literal.rs Outdated Show resolved Hide resolved
@panarch panarch self-requested a review April 6, 2023 15:12
@ChobobDev
Copy link
Contributor Author

I have made changes, thank you for the review :)

panarch
panarch approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution.
Looks all great!
Let's ship these features to the main 👍

@panarch panarch changed the title feat : add new unsigned integer data type Add UINT32, UINT64 and UINT128 data type Apr 6, 2023
@panarch panarch changed the title Add UINT32, UINT64 and UINT128 data type Add UINT32, UINT64 and UINT128 data types Apr 6, 2023
@panarch panarch merged commit 85b29e9 into gluesql:main Apr 6, 2023
@ChobobDev ChobobDev deleted the feature/uint_data_type branch April 6, 2023 15:20
@ever0de ever0de mentioned this pull request Apr 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@ever0de ever0de Awaiting requested review from ever0de

@devgony devgony Awaiting requested review from devgony

Assignees

@ChobobDev ChobobDev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChobobDev @coveralls @panarch @ever0de