Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ValueError::InvalidJsonString error to show input text #1018

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Update ValueError::InvalidJsonString error to show input text #1018

merged 1 commit into from
Nov 24, 2022

Conversation

panarch
Copy link
Member

@panarch panarch commented Nov 23, 2022

cc. @ShaddyDC

@panarch panarch added the improvement Improvements for existing features label Nov 23, 2022
@panarch panarch requested review from ever0de and devgony November 23, 2022 13:26
@panarch panarch self-assigned this Nov 23, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3532462484

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 98.661%
Files with Coverage Reduction New Missed Lines %
core/src/executor/validate.rs 1 99.32%
Totals Coverage Status
Change from base Build 3521729689: 0.1%
Covered Lines: 36476
Relevant Lines: 36971
💛 - Coveralls

@panarch panarch merged commit f764d24 into main Nov 24, 2022
@panarch panarch deleted the more-info-to-invalid-json-string-error branch November 24, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ever0de ever0de ever0de approved these changes

@devgony devgony Awaiting requested review from devgony

Assignees

@panarch panarch

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panarch @coveralls @ever0de