Resolve unreachable branch of Value::position
#1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panarch
reviewed
Nov 19, 2022
test-suite/src/function/position.rs
Outdated
| @@ -25,7 +28,11 @@ test_case!(position, async move { | |||
| ), | |||
| ( | |||
| "SELECT POSITION(1 IN 'cheese') AS test", | |||
| Err(EvaluateError::FunctionRequiresStringValue(String::from("POSITION")).into()), | |||
| Err(ValueError::UnSupportedValueByPositionFunction { | |||
There was a problem hiding this comment.
nit. Unsupported would be good.
Pull Request Test Coverage Report for Build 3502363132
💛 - Coveralls |
ever0de
force-pushed
the
fix-unreachable-branch
branch
from
d602daf to
0b8b710
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit test coverage is satisfied, but the error branch that did not appear in the user interface
Glue::executeis corrected.If it were not for this fix, the position function would probably be correct to receive a String rather than a
Value.