Add error test

gluesql · Feb 5, 2022 · 3056085 · 3056085
1 parent 4a261c8
commit 3056085
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/core/src/translate/error.rs b/core/src/translate/error.rs
@@ -15,7 +15,7 @@ pub enum TranslateError {
     JoinOnUpdateNotSupported,
 
     #[error("unimplemented - compound identifier on update not supported: {0}")]
-    CompoundIndentOnUpdateNotSupported(String),
+    CompoundIdentOnUpdateNotSupported(String),
 
     #[error("too many params in drop index")]
     TooManyParamsInDropIndex,

diff --git a/core/src/translate/mod.rs b/core/src/translate/mod.rs
@@ -158,7 +158,7 @@ fn translate_assignment(sql_assignment: &SqlAssignment) -> Result<Assignment> {
 
     if id.len() > 1 {
         return Err(
-            TranslateError::CompoundIndentOnUpdateNotSupported(sql_assignment.to_string()).into(),
+            TranslateError::CompoundIdentOnUpdateNotSupported(sql_assignment.to_string()).into(),
         );
     }
 

diff --git a/test-suite/src/error.rs b/test-suite/src/error.rs
@@ -70,6 +70,18 @@ test_case!(error, async move {
             TranslateError::UnsupportedJoinOperator("CrossJoin".to_owned()).into(),
             "SELECT * FROM TableA CROSS JOIN TableA as A;",
         ),
+        (
+            TranslateError::JoinOnUpdateNotSupported.into(),
+            "UPDATE TableA INNER JOIN TableA ON 1 = 1 SET 1 = 1",
+        ),
+        (
+            TranslateError::UnsupportedTableFactor("(SELECT * FROM TableA)".to_owned()).into(),
+            "UPDATE (SELECT * FROM TableA) SET 1 = 1",
+        ),
+        (
+            TranslateError::CompoundIdentOnUpdateNotSupported("TableA.id = 1".to_owned()).into(),
+            "UPDATE TableA SET TableA.id = 1 WHERE id = 1",
+        ),
         (
             EvaluateError::NestedSelectRowNotFound.into(),
             "SELECT * FROM TableA WHERE id = (SELECT id FROM TableA WHERE id = 2);",