feat(ui): add package detail page #172 #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophenne
force-pushed
the
christoph/package-details
branch
from
1b0d09b to
e1fef48
Compare
christophenne
commented
Feb 13, 2024
christophenne
force-pushed
the
christoph/package-details
branch
from
e1fef48 to
4b2f242
Compare
1 task
christophenne
force-pushed
the
christoph/package-details
branch
from
4b2f242 to
f9aa45c
Compare
kosmoz
requested changes
Feb 14, 2024
christophenne
force-pushed
the
christoph/package-details
branch
from
f9aa45c to
926a58b
Compare
kosmoz
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #172
📑 Description
This PR introduces the package detail page, as well as the corresponding changes to the package overview page. The actions available for each package are different on the two views, so I split them into two "components" (template + some controller functions).
For the new details appearing on the detail page, the PackageManifest schema had to be changed, this is the corresponding PR in the packages repo: glasskube/packages#24
I also did some refactoring which almost got a little out of hand:
✅ Checks
ℹ Additional Information