fix: simplify identifying caller #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkampitakis
force-pushed
the
basecaller_issue
branch
2 times, most recently
from
cc0c6aa to
e29ffb5
Compare
gkampitakis
changed the title
gkampitakis
force-pushed
the
basecaller_issue
branch
from
e29ffb5 to
134f13d
Compare
mergify bot
referenced
this pull request
in dbsystel/cdk-sops-secrets
May 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/aws/aws-sdk-go](https://togithub.com/aws/aws-sdk-go) | require | patch | `v1.44.266` -> `v1.44.267` | | [github.com/gkampitakis/go-snaps](https://togithub.com/gkampitakis/go-snaps) | require | patch | `v0.4.3` -> `v0.4.4` | --- ### Release Notes <details> <summary>aws/aws-sdk-go</summary> ### [`v1.44.267`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v144267-2023-05-22) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.44.266...v1.44.267) \=== ##### Service Client Updates - `service/backup`: Updates service API and documentation - `service/pinpoint`: Updates service documentation - Amazon Pinpoint is deprecating the tags parameter in the UpdateSegment, UpdateCampaign, UpdateEmailTemplate, UpdateSmsTemplate, UpdatePushTemplate, UpdateInAppTemplate and UpdateVoiceTemplate. Amazon Pinpoint will end support tags parameter by May 22, 2023. - `service/quicksight`: Updates service API, documentation, and paginators - Add support for Asset Bundle, Geospatial Heatmaps. ##### SDK Bugs - `rest`: Revert removing unnecessary path normalization behavior. - This behavior would mutate request paths with URI-encoded characters, potentially resulting in misrouted requests. - `config`: Revert deprecating `DisableRestProtocolURICleaning` config setting. - This setting will have an effect again. REST-protocol paths will now be normalized after serialization. </details> <details> <summary>gkampitakis/go-snaps</summary> ### [`v0.4.4`](https://togithub.com/gkampitakis/go-snaps/releases/tag/v0.4.4) [Compare Source](https://togithub.com/gkampitakis/go-snaps/compare/v0.4.3...v0.4.4) #### What's Changed - fix: clean snapshots should only delete .snap files by [@​gkampitakis](https://togithub.com/gkampitakis) in [https://github.com/gkampitakis/go-snaps/pull/62](https://togithub.com/gkampitakis/go-snaps/pull/62) - fix: simplify identifying caller by [@​gkampitakis](https://togithub.com/gkampitakis) in [https://github.com/gkampitakis/go-snaps/pull/61](https://togithub.com/gkampitakis/go-snaps/pull/61) - handle running `go-snaps` from godog **Full Changelog**: gkampitakis/go-snaps@v0.4.3...v0.4.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/markussiebert/cdk-sops-secrets).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the issue reported by @zregvart at https://github.com/gkampitakis/go-snaps/pull/60/files#r1197658271
It also simplifies the
packagetestcase.This was tested with some out of the repo tests including
tools/go/packages/packagesteststretchr/testify/suiteadamluzsi/testcasematchSnapshotsfrom a goroutine.