feat: support matchStandaloneSnapshot #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkampitakis
force-pushed
the
matchStandaloneSnapshot
branch
2 times, most recently
from
d94c65a to
63da2c9
Compare
gkampitakis
force-pushed
the
matchStandaloneSnapshot
branch
from
63da2c9 to
c1316de
Compare
gkampitakis
force-pushed
the
matchStandaloneSnapshot
branch
2 times, most recently
from
b8702af to
f0114f8
Compare
gkampitakis
force-pushed
the
matchStandaloneSnapshot
branch
from
f0114f8 to
a34dc31
Compare
gkampitakis
commented
Jul 21, 2024
...StandaloneSnapshot_test_TestMatchStandaloneSnapshot_should_create_html_snapshots_1.snap.html
Outdated
Show resolved
Hide resolved
|
Hi @gkampitakis! Thanks for putting this together. I was in the midst of looking for a way to save snapshot files with a Do you have a timeline around releasing this change? Thanks again! |
Hey @jeremyhcho, thanks for your interest. I have been quite busy this week, but hopefully I will make progress and manage to merge it this weekend if I don't encounter any issue as this pr is mostly done 😄 . If you want to test it and provide any feedback you are welcome to try it with |
hogo6002
referenced
this pull request
in google/osv-scanner
Jul 29, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/gkampitakis/go-snaps](https://togithub.com/gkampitakis/go-snaps) | `v0.5.5` -> `v0.5.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/urfave/cli/v2](https://togithub.com/urfave/cli) | `v2.27.2` -> `v2.27.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>gkampitakis/go-snaps (github.com/gkampitakis/go-snaps)</summary> ### [`v0.5.6`](https://togithub.com/gkampitakis/go-snaps/releases/tag/v0.5.6) [Compare Source](https://togithub.com/gkampitakis/go-snaps/compare/v0.5.5...v0.5.6) #### What's Changed - feat: support matchStandaloneSnapshot by [@​gkampitakis](https://togithub.com/gkampitakis) in [https://github.com/gkampitakis/go-snaps/pull/102](https://togithub.com/gkampitakis/go-snaps/pull/102) - feat: support setting file extension by [@​gkampitakis](https://togithub.com/gkampitakis) in [https://github.com/gkampitakis/go-snaps/pull/102](https://togithub.com/gkampitakis/go-snaps/pull/102) **Full Changelog**: gkampitakis/go-snaps@v0.5.5...v0.5.6 </details> <details> <summary>urfave/cli (github.com/urfave/cli/v2)</summary> ### [`v2.27.3`](https://togithub.com/urfave/cli/releases/tag/v2.27.3) [Compare Source](https://togithub.com/urfave/cli/compare/v2.27.2...v2.27.3) #### What's Changed - v2 Docs: Mention value from env as default value by [@​sj14](https://togithub.com/sj14) in [https://github.com/urfave/cli/pull/1910](https://togithub.com/urfave/cli/pull/1910) - Bump github.com/xrash/smetrics dependency by [@​elezar](https://togithub.com/elezar) in [https://github.com/urfave/cli/pull/1911](https://togithub.com/urfave/cli/pull/1911) - fix: disable bash completion if double dash is included in arguments (v2) by [@​suzuki-shunsuke](https://togithub.com/suzuki-shunsuke) in [https://github.com/urfave/cli/pull/1938](https://togithub.com/urfave/cli/pull/1938) - Fix improper whitespace formatting in usageTemplate, AppHelpTemplate … by [@​caeret](https://togithub.com/caeret) in [https://github.com/urfave/cli/pull/1947](https://togithub.com/urfave/cli/pull/1947) #### New Contributors - [@​sj14](https://togithub.com/sj14) made their first contribution in [https://github.com/urfave/cli/pull/1910](https://togithub.com/urfave/cli/pull/1910) - [@​elezar](https://togithub.com/elezar) made their first contribution in [https://github.com/urfave/cli/pull/1911](https://togithub.com/urfave/cli/pull/1911) - [@​caeret](https://togithub.com/caeret) made their first contribution in [https://github.com/urfave/cli/pull/1947](https://togithub.com/urfave/cli/pull/1947) **Full Changelog**: urfave/cli@v2.27.2...v2.27.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/google/osv-scanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #100
Note
The new method can show false positives for obsolete files when using
snaps.Skip*or-run.Also similarly to other methods if the file is the last in a directory and it's obsolete go-snaps won't mark it as obsolete as it can't discover it.