feat: add support for SVG images in ImageZoom component #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
housseindjirdeh
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
Description
Added support for remote SVG images in the ImageZoom component.
The idea is to still use the
<Image>component from React Native, andonError, letreact-native-svg-from-uritake a chance at rendering.(I forked
react-native-svg-from-urifromreact-native-svg-uriwhich is not maintained anymore, and fixed some text rendering issues that made me walk away when I first tried this lib a while ago.)SVG are not zoomable for now, as react-native-photo-view doesn't support SVG. No biggies IMHO, cause most of the times, SVG images in markdown comments are badges.
This needs to be tested on more badges / issues 🖐