feat(members): add gradient to members list #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add react-native-linear-gradient package
Adds a gradient to the right and left side in the members scroll list. Also removes the `marginRight` from the last avatar in the list.
Adds me as contributor.
lex111
reviewed
Oct 20, 2017
src/components/members.component.js
Outdated
| marginLeft: 15, | ||
| marginRight: 15, | ||
| paddingLeft: 15, | ||
| paddingRight: 15, |
There was a problem hiding this comment.
This can be simplified: instead of paddingLeft and paddingRight, use paddingHorizontal.
Add missed updated files running `react-native link`.
Change `paddingRight/Left` to `paddingHorizontal`.
|
This looks outstanding! Thanks so much @ocarreterom!! |
lex111
approved these changes
Oct 20, 2017
housseindjirdeh
approved these changes
Oct 21, 2017
| }, | ||
| { | ||
| "login": "ocarreterom", | ||
| "name": "Óscar Carretero", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a gradient to the right and left side in the members scroll list.
Also removes the
marginRightfrom the last avatar in the list.