Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(android): Compile animated gifs support #446

Merged
merged 1 commit into from
Oct 8, 2017
Merged

chore(android): Compile animated gifs support #446

merged 1 commit into from
Oct 8, 2017

Conversation

machour
Copy link
Member

@machour machour commented Oct 7, 2017

Fixes #443

lex111
lex111 reviewed Oct 7, 2017
View reviewed changes
android/app/build.gradle
@@ -145,6 +145,7 @@ dependencies {
compile fileTree(dir: "libs", include: ["*.jar"])
compile "com.android.support:appcompat-v7:23.0.1"
compile "com.facebook.react:react-native:+" // From node_modules
compile "com.facebook.fresco:animated-gif:1.3.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion: you can add comment as similar to 147 line for clarity:

// For animated GIF support

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lex111 I thought so, but I find the library name quiet explicit.

housseindjirdeh
housseindjirdeh approved these changes Oct 8, 2017
View reviewed changes
Copy link
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaas thank you for this, apologies for not catching it not working on android when I did my final regression tests before release 😞

@housseindjirdeh housseindjirdeh merged commit 554e1cc into gitpoint:master Oct 8, 2017
@machour machour deleted the android-animated-gifs branch October 12, 2017 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@housseindjirdeh housseindjirdeh housseindjirdeh approved these changes

@andrewda andrewda andrewda approved these changes

@lex111 lex111 lex111 approved these changes

Assignees
No one assigned
Labels
android ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@machour @lex111 @andrewda @housseindjirdeh