Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove with-helm and associated functions #9964

Merged
merged 1 commit into from
May 12, 2022

Conversation

liam-j-bennett
Copy link
Contributor

@liam-j-bennett liam-j-bennett commented May 12, 2022

Description

Removes the now unused with-helm parameter and underlying functions

Related Issue(s)

Fixes #9844

Release Notes

Remove the with-helm option for running preview environments

Copy link
Member

@meysholdt meysholdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to see so many LOC go away :-D
Code changes LGTM 🚀

@liam-j-bennett
Copy link
Contributor Author

/release-note-none

@liam-j-bennett
Copy link
Contributor Author

liam-j-bennett commented May 12, 2022

/werft run

👍 started the job as gitpod-build-liam-j-bennett-remove-with-helm-9844.2
(with .werft/ from main)

@roboquat roboquat merged commit 0a31946 into main May 12, 2022
@roboquat roboquat deleted the liam-j-bennett/remove-with-helm-9844 branch May 12, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "with-helm=true" support from Preview Environments
3 participants