Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a special domain name for SSH Gateway #9786

Merged
merged 1 commit into from
May 5, 2022
Merged

Use a special domain name for SSH Gateway #9786

merged 1 commit into from
May 5, 2022

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented May 5, 2022 •
edited
Loading

Description

Use a special domain name for SSH Gateway, This has a big advantage for self-hosted users, who can set up another loadbalancer for this separate domain without breaking their original loadbalancer or ingress

Related Issue(s)

Fixes #

How to test

  1. Download this special Gateway Plugin https://plugins.jetbrains.com/plugin/18438-gitpod-gateway/versions/Dev/172691
  2. Open a workspace with any Jetbrains Client
  3. Click More Action -> Connect via SSH, make sure hostname part of ssh command is workspaceId.ssh.pd-simple-ssh-host.preview.gitpod-dev.com

image

image

  1. Click Open with xxx Jetbrains IDE to open Jetbrains Gateway to ensure everything should works as normal

Release Notes

Use a special domain name for SSH Gateway

Documentation

@iQQBot iQQBot requested review from a team May 5, 2022 08:22
@github-actions github-actions bot added team: IDE team: webapp Issue belongs to the WebApp team labels May 5, 2022
@akosyakov akosyakov mentioned this pull request May 5, 2022
Merged
akosyakov
akosyakov approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work

geropl
geropl approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@roboquat roboquat merged commit af26333 into main May 5, 2022
@roboquat roboquat deleted the pd/simple-ssh-host branch May 5, 2022 08:34
@iQQBot iQQBot mentioned this pull request May 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov approved these changes

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
release-note size/XS team: IDE team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iQQBot @akosyakov @geropl @roboquat