Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] Disable search indexing of all web app pages #9622

Merged
merged 1 commit into from
Apr 28, 2022
Merged

[dashboard] Disable search indexing of all web app pages #9622

merged 1 commit into from
Apr 28, 2022

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Apr 28, 2022 •
edited
Loading

Description

Disable search indexing of all web app pages.

Sources:

Related Issue(s)

Fixes #9607
Fixes #3980
Fixes #8508

How to test

  1. Merge this PR
  2. Deploy to production
  3. Make the Google crawler re-index the dashboard (e.g. via the Google Search Console)
  4. Verify that dashboard pages no longer show up in Google Search results

Release Notes

[dashboard] Disable search indexing of all web app pages

Documentation

@jankeromnes jankeromnes requested a review from a team April 28, 2022 13:38
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 28, 2022
geropl
geropl approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit f6a76a9 into main Apr 28, 2022
@roboquat roboquat deleted the jx/de-index branch April 28, 2022 14:16
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 4, 2022
@chrifro chrifro mentioned this pull request Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
3 participants
@jankeromnes @geropl @roboquat