Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ws-daemon] Check blkio throttle exists #9493

Merged
merged 1 commit into from
Apr 22, 2022
Merged

[ws-daemon] Check blkio throttle exists #9493

merged 1 commit into from
Apr 22, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 22, 2022

Description

Remove useless log https://cloudlogging.app.goo.gl/YcGHidiz6YFSa8T58

Release Notes

[ws-daemon] Check blkio throttle exists

@aledbf aledbf requested a review from a team April 22, 2022 12:47
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Apr 22, 2022
Furisto
Furisto previously approved these changes Apr 22, 2022
View reviewed changes
csweichel
csweichel reviewed Apr 22, 2022
View reviewed changes
Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

components/ws-daemon/pkg/cgroup/plugin_iolimit_v1.go Outdated Show resolved Hide resolved
components/ws-daemon/pkg/cgroup/plugin_iolimit_v1.go Outdated Show resolved Hide resolved
@aledbf aledbf requested a review from csweichel April 22, 2022 15:19
@roboquat roboquat merged commit bfa4c16 into main Apr 22, 2022
@roboquat roboquat deleted the aledbf/blkio branch April 22, 2022 15:27
@kylos101
Copy link
Contributor

Added to our changelog

@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Apr 23, 2022
@meysholdt meysholdt mentioned this pull request Apr 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csweichel csweichel csweichel approved these changes

@Furisto Furisto Furisto left review comments

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aledbf @kylos101 @csweichel @Furisto @roboquat