Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] Make sure we have the auth cookie set before redirecting to the workspace URL #9488

Merged
merged 1 commit into from
Apr 22, 2022
Merged

[dashboard] Make sure we have the auth cookie set before redirecting to the workspace URL #9488

merged 1 commit into from
Apr 22, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Apr 22, 2022 •
edited
Loading

Description

Related Issue(s)

Fixes #9145

How to test

Release Notes

fix a dashboard bug where you might end up on a workspace without having access to it

Documentation

@geropl
Copy link
Member Author

geropl commented Apr 22, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-vm=true

👍 started the job as gitpod-build-gpl-9145-ensureauth.2

@geropl
Copy link
Member Author

geropl commented Apr 22, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-vm=true with-clean-slate-deployment=true

👍 started the job as gitpod-build-gpl-9145-ensureauth.3

@geropl geropl marked this pull request as ready for review April 22, 2022 10:30
@geropl geropl requested a review from a team April 22, 2022 10:30
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 22, 2022
easyCZ
easyCZ approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@roboquat roboquat merged commit b2d07b8 into main Apr 22, 2022
@roboquat roboquat deleted the gpl/9145-ensureauth branch April 22, 2022 12:51
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[StartWorkspace] Make sure ensureWorkspaceAuth is called
3 participants
@geropl @easyCZ @roboquat