Push to KOTS on each branch #9014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsimonemms
force-pushed
the
sje/replicated-werft
branch
2 times, most recently
from
3a1d91f
to
9315657
Compare
It either pushes to the "unstable" channel if on the main branch, or the branch name if not.
mrsimonemms
force-pushed
the
sje/replicated-werft
branch
from
9315657
to
ebbcef2
Compare
mrsimonemms
changed the title
Pothulapati
approved these changes
Mar 30, 2022
There was a problem hiding this comment.
LGTM! Initially, definitely worried that we'll get a lot of channels this way! but as each branch is a single PR, and a channel is how you install things (latest release on the channel), This way makes more sense!
A future PR to auto-delete channels when unused may need to be done in future
We should definitely do this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It either pushes to the "unstable" channel if on the main branch, or the branch name if not. This makes KOTS a first-class citizen in the Gitpod testing process
A future PR to auto-delete channels when unused may need to be done in future
How to test
Release Notes
Documentation