Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sidebar menu colors #9002

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Improve sidebar menu colors #9002

merged 1 commit into from
Mar 29, 2022

Conversation

gtsiolis
Copy link
Contributor

Description

This will update the sidebar menu colors to match the specs in #7932.

Related Issue(s)

Fixes #7932

How to test

  1. Go to a page in user settings like /preferences
  2. Notice the color difference of the sidebar menu.

Screenshots

BEFORE AFTER
sidebar-before sidebar-after

Release Notes

Improve sidebar menu colors

@gtsiolis gtsiolis requested a review from a team March 29, 2022 13:21
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 29, 2022
easyCZ
easyCZ approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 26f35e4 into main Mar 29, 2022
@roboquat roboquat deleted the gt/improve-sidebar-colors branch March 29, 2022 13:28
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 29, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Thanks, @easyCZ! 🏀

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 31, 2022
@jankeromnes jankeromnes mentioned this pull request Mar 31, 2022
Merged
@jankeromnes
Copy link
Contributor

jankeromnes commented Mar 31, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Follow-up PR for Dark theme 😇 #9052

@gtsiolis gtsiolis mentioned this pull request Apr 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update card selector component and sidebar design
4 participants
@gtsiolis @jankeromnes @easyCZ @roboquat