Remove re-run from /prebuilds, redirect to logs when rerunning #8835

laushinka · 2022-03-16T06:28:42Z

Description

Disallows actions in the /prebuilds page
When rerunning a prebuild in the branches page, it directs to the prebuild logs view.

Related Issue(s)

Fixes #8765

How to test

https://laushinka-5100f6fadc.staging.gitpod-dev.com/projects

Add a project and run prebuilds that fail.
Rerun a prebuild for the failed one.

Release Notes

Rerunning prebuilds direct to the prebuild logs view, and rerunning is not allowed from the /prebuilds page.

Documentation

jldec · 2022-03-16T20:18:40Z

This is good - thanks @laushinka .

The only change I would suggest (and I know this is slightly different from what was discussed in #8765) would be to remove the context dots menu from the prebuilds list entirely, and link the whole list item to the prebuild detail. If that is a running prebuild, then the Cancel action can be performed there, so we don't need it in the prebuilds list. This would improve usability and simplify the experience of navigating between the prebuilds list, and the prebuilds detail.

jldec

small change in navigation behavior requested in the comment

jldec · 2022-03-16T20:21:00Z

Redirecting from the branches list to the prebuild detail, when a prebuild is started, is a nice improvement.

laushinka · 2022-03-17T13:46:45Z

@gtsiolis I implemented a spinner but I think I could use your review here on the positioning 🙏🏽

laushinka · 2022-03-17T15:45:22Z

It shows build failed but that's actually an old one 🤔 The preview env is green[1]

gtsiolis · 2022-03-17T15:47:19Z

Looking at this now! 👀

gtsiolis

Thanks for the ping, @laushinka! 🏓

Left two comments below.

gtsiolis · 2022-03-17T15:55:22Z

components/dashboard/src/projects/Project.tsx

+            <div>
+                {isLoading && (
+                    <div className="flex justify-center">
+                        <img alt="" className="h-4 w-4 animate-spin" src={Spinner} />
+                    </div>
+                )}
+            </div>


issue: This placed spinner at the bottom of the branches list ~~can definitely~~ could*** cause some confusion, especially if the branches list is long, etc.

*** @laushinka Sorry if the initial wording here felt a bit strong. 🙏

You're absolutely right 🙏🏽 I'll find a different position for it

thought: If we don't have a page we can render instantly I'd avoid the redirect in the first place.

gtsiolis · 2022-03-17T15:55:28Z

components/dashboard/src/projects/Project.tsx

+            <div>
+                {isLoading && (
+                    <div className="flex justify-center">
+                        <img alt="" className="h-4 w-4 animate-spin" src={Spinner} />
+                    </div>
+                )}
+            </div>


suggestion: Redirecting to the prebuild details page as @jldec described in #8835 (comment) sounds great, could we go with that approach? The prebuild details page already contains a loading indicator (spinner) at the bottom right? If for some reason the prebuild does not exist or the page is not available before some time we could introduce a new prebuild phase so that on trigger there's always a phase we can load and link to.

Let me now what you think, @laushinka! 💭

Loading indicator (spinner) on the prebuild details page

Yes that would be ideal, unfortunately the spinner is necessary here because it takes a while until we get a response back to know which prebuild logs page to go to..

Alternatively, we could not attempt to redirect until we have a page we can render in time.

Alternatively, we could not attempt to redirect until we have a page we can render in time.

Hmm, how would the UX be like here? Also looping in @jldec

Showing a spinner near the action that the user clicked, and then redirecting after a pause, is still preferable over not redirecting at all.

jldec · 2022-03-18T14:48:51Z

/werft run with-vm=true

👍 started the job as gitpod-build-laushinka-dashboard-remove-action-8765.14

jldec

LGTM

laushinka · 2022-03-21T07:35:20Z

@gtsiolis We can improve the spinner and the general behavior of the prebuilds page in a follow-up issue 🙏🏽 cc @jldec because we talked about it briefly.

roboquat added do-not-merge/work-in-progress do-not-merge/release-note-label-needed size/S labels Mar 16, 2022

laushinka changed the title ~~try~~ Remove re-run from /prebuilds, redirect to logs when rerunning Mar 16, 2022

laushinka force-pushed the laushinka/dashboard-remove-action-8765 branch 2 times, most recently from c0ab888 to 3b58e1e Compare March 16, 2022 17:26

laushinka marked this pull request as ready for review March 16, 2022 17:28

laushinka requested review from a team, jldec and geropl March 16, 2022 17:28

roboquat added release-note and removed do-not-merge/work-in-progress do-not-merge/release-note-label-needed labels Mar 16, 2022

jldec suggested changes Mar 16, 2022

View reviewed changes

laushinka force-pushed the laushinka/dashboard-remove-action-8765 branch from 3b58e1e to bf23c34 Compare March 17, 2022 13:34

roboquat added size/M and removed size/S labels Mar 17, 2022

laushinka requested review from jldec and gtsiolis March 17, 2022 14:30

gtsiolis reviewed Mar 17, 2022

View reviewed changes

roboquat added size/L and removed size/M labels Mar 17, 2022

laushinka force-pushed the laushinka/dashboard-remove-action-8765 branch 3 times, most recently from 6bfd371 to fdbb269 Compare March 18, 2022 13:35

Disallow actions in prebuilds page

dc4d236

laushinka force-pushed the laushinka/dashboard-remove-action-8765 branch from fdbb269 to dc4d236 Compare March 18, 2022 15:45

jldec approved these changes Mar 18, 2022

View reviewed changes

roboquat merged commit 6721143 into main Mar 18, 2022

roboquat deleted the laushinka/dashboard-remove-action-8765 branch March 18, 2022 16:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove re-run from /prebuilds, redirect to logs when rerunning #8835

Remove re-run from /prebuilds, redirect to logs when rerunning #8835

laushinka commented Mar 16, 2022 •

edited

Loading

jldec commented Mar 16, 2022

jldec left a comment

jldec commented Mar 16, 2022

laushinka commented Mar 17, 2022 •

edited by werft-gitpod-dev-com bot

Loading

laushinka commented Mar 17, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Mar 17, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis left a comment

gtsiolis Mar 17, 2022 •

edited

Loading

laushinka Mar 17, 2022

gtsiolis Mar 17, 2022 •

edited

Loading

gtsiolis Mar 17, 2022 •

edited

Loading

laushinka Mar 17, 2022

gtsiolis Mar 17, 2022

laushinka Mar 18, 2022

jldec Mar 18, 2022

jldec commented Mar 18, 2022 •

edited by werft-gitpod-dev-com bot

Loading

jldec left a comment

laushinka commented Mar 21, 2022 •

edited

Loading

Remove re-run from /prebuilds, redirect to logs when rerunning #8835

Remove re-run from /prebuilds, redirect to logs when rerunning #8835

Conversation

laushinka commented Mar 16, 2022 • edited Loading

Description

Related Issue(s)

How to test

Release Notes

Documentation

jldec commented Mar 16, 2022

jldec left a comment

Choose a reason for hiding this comment

jldec commented Mar 16, 2022

laushinka commented Mar 17, 2022 • edited by werft-gitpod-dev-com bot Loading

laushinka commented Mar 17, 2022 • edited by werft-gitpod-dev-com bot Loading

gtsiolis commented Mar 17, 2022 • edited by werft-gitpod-dev-com bot Loading

gtsiolis left a comment

Choose a reason for hiding this comment

gtsiolis Mar 17, 2022 • edited Loading

Choose a reason for hiding this comment

laushinka Mar 17, 2022

Choose a reason for hiding this comment

gtsiolis Mar 17, 2022 • edited Loading

Choose a reason for hiding this comment

gtsiolis Mar 17, 2022 • edited Loading

Choose a reason for hiding this comment

laushinka Mar 17, 2022

Choose a reason for hiding this comment

gtsiolis Mar 17, 2022

Choose a reason for hiding this comment

laushinka Mar 18, 2022

Choose a reason for hiding this comment

jldec Mar 18, 2022

Choose a reason for hiding this comment

jldec commented Mar 18, 2022 • edited by werft-gitpod-dev-com bot Loading

jldec left a comment

Choose a reason for hiding this comment

laushinka commented Mar 21, 2022 • edited Loading

laushinka commented Mar 16, 2022 •

edited

Loading

laushinka commented Mar 17, 2022 •

edited by werft-gitpod-dev-com bot

Loading

laushinka commented Mar 17, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Mar 17, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis Mar 17, 2022 •

edited

Loading

gtsiolis Mar 17, 2022 •

edited

Loading

gtsiolis Mar 17, 2022 •

edited

Loading

jldec commented Mar 18, 2022 •

edited by werft-gitpod-dev-com bot

Loading

laushinka commented Mar 21, 2022 •

edited

Loading