[installer]: add image pull secrets and custom image registry #6983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
added
release-note
do-not-merge/work-in-progress
team: workspace
Codecov Report
@@ Coverage Diff @@
## main #6983 +/- ##
========================================
- Coverage 7.52% 5.76% -1.77%
========================================
Files 15 13 -2
Lines 1315 1162 -153
========================================
- Hits 99 67 -32
+ Misses 1213 1094 -119
+ Partials 3 1 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mrsimonemms
force-pushed
the
sje/installer-gp-img-pull-secrets
branch
2 times, most recently
from
b79f9e9
to
0532649
Compare
mrsimonemms
changed the title
mrsimonemms
force-pushed
the
sje/installer-gp-img-pull-secrets
branch
3 times, most recently
from
004cf95
to
e52fc72
Compare
mrsimonemms
force-pushed
the
sje/installer-gp-img-pull-secrets
branch
from
e52fc72
to
036f7bc
Compare
|
did not test this, but code lgtm /lgtm |
|
LGTM label has been added. Git tree hash: 57172b589fe24af9fdb3620b47085322b4cc3b9a
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel, geropl Associated issue: #6756 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add image pull secrets to Gitpod components
Limitations
The limitations are related to the registry-facade only having a single
.dockerconfigjsonset to/mnt/pull-secret.jsonas the configmap only allows a singleAuthCfg. This means that images such asdocker-upandsupervisorwon't be downloaded if using a different repository. If we decide to support the above two limitations, theAuthCfgwill need to accept an array of pull secrets.Mirroring
For external image names, the convention of
path/nameis followed which will make it easier to mirror. This means that anything in docker.io is written out in full - eg,alpinebecomeslibrary/alpine. Any Gitpod images just have the given container registry replaced fully - eg,eu.gcr.io/gitpod-core-dev/build/agent-smithbecomesmynewrepo.com/agent-smithA simple bash script to mirror images to your own registry is contained in #6756
Related Issue(s)
Fixes #6979
Fixes #6989
Fixes #6990
How to test
I have a private container registry with the images in. Can share/demo when necessary
Release Notes
Documentation