Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] Gitpod walkthrough #6095

Merged
merged 1 commit into from
Oct 12, 2021
Merged

[code] Gitpod walkthrough #6095

merged 1 commit into from
Oct 12, 2021

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Oct 7, 2021

Description

Update latest VS Code to bring Gitpod walkthrough: gitpod-io/openvscode-server#110

Gitpod Code commit: gitpod-io/openvscode-server@128bab1

Related Issue(s)

Related to #5964

How to test

Release Notes

VS Code: Add a Get Started with Gitpod walkthrough

@akosyakov
Copy link
Member Author

@mikenikles does it resolve #5964?

@akosyakov
Copy link
Member Author

@mikenikles I tried it but it somehow broken, I cannot click on links in the walkthrough.

@mikenikles
Copy link
Contributor

mikenikles commented Oct 7, 2021

Nope, #5964 is a follow-up with a few enhancements. I don't think there's an open issue for the work in this PR.

Regular hyperlinks to docs etc seem to work, the two that are now broken for some reason are the ones that execute a command, e.g. open the ports panel or run a terminal command.

I'm looking into it 👀

Update: I spent another hour looking into it. This was tested by various people in the openvscode-server repo PR. Even when I try it in that repo, the commands no longer work now. I tested with stable and Insider VS Code, same problem. I also don't see anything in the logs. At this point, I can't explain what's going on. Maybe a good night's sleep and another look tomorrow will reveal more.

@akosyakov
Copy link
Member Author

Update: I spent another hour looking into it. This was tested by various people in the openvscode-server repo PR. Even when I try it in that repo, the commands no longer work now. I tested with stable and Insider VS Code, same problem. I also don't see anything in the logs. At this point, I can't explain what's going on. Maybe a good night's sleep and another look tomorrow will reveal more.

Maybe I broke something while rebasing, could you try again in openvscode-server directly?

@corneliusludmann
Copy link
Contributor

corneliusludmann commented Oct 12, 2021

/werft run

👍 started the job as gitpod-build-ak-gitpod-walkthrough.1

@corneliusludmann
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4a0f2090a00d7e1e8d745141c4ca282a545044a0

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusludmann

Associated issue: #5964

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 95c6a7f into main Oct 12, 2021
@roboquat roboquat deleted the ak/gitpod_walkthrough branch October 12, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants