Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] Fix alignment of pending changes widget in workspaces list #4986

Merged
merged 1 commit into from
Jul 29, 2021
Merged

[dashboard] Fix alignment of pending changes widget in workspaces list #4986

merged 1 commit into from
Jul 29, 2021

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Jul 28, 2021 •
edited
Loading

Fixes #4670

Now looks like this:

Screenshot 2021-07-29 at 14 34 29

@jankeromnes jankeromnes force-pushed the jx/realign-pending-changes branch 2 times, most recently from 3db3b46 to bae147f Compare July 28, 2021 14:56
@codecov
Copy link

codecov bot commented Jul 28, 2021 •
edited
Loading

Codecov Report

Merging #4986 (4e0460b) into main (698a17b) will increase coverage by 13.51%.
The diff coverage is 0.00%.

❗ Current head 4e0460b differs from pull request most recent head 3a95305. Consider uploading reports for the commit 3a95305 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4986       +/-   ##
===========================================
+ Coverage   23.02%   36.54%   +13.51%     
===========================================
  Files          11       13        +2     
  Lines        1915     3719     +1804     
===========================================
+ Hits          441     1359      +918     
- Misses       1415     2244      +829     
- Partials       59      116       +57
Flag Coverage Δ
components-ws-daemon-app ?
components-ws-manager-app 36.54% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-manager/pkg/manager/monitor.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/status.go 71.57% <0.00%> (ø)
components/ws-daemon/pkg/quota/size.go
components/ws-daemon/pkg/content/initializer.go
...onents/ws-daemon/pkg/internal/session/workspace.go
components/ws-daemon/pkg/resources/dispatch.go
components/ws-daemon/pkg/content/archive.go
components/ws-daemon/pkg/resources/controller.go
components/ws-daemon/pkg/internal/session/store.go
components/ws-daemon/pkg/content/tar.go
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 698a17b...3a95305. Read the comment docs.

@roboquat roboquat added size/M and removed size/S labels Jul 28, 2021
@csweichel
Copy link
Contributor

/hold

please don't merge all those reverts

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Jul 28, 2021 •
edited
Loading

please don't merge all those reverts

Agreed. I'm blindly reverting anything "suspicious" until workspace backups work again 😇 (because I need a successful backup in order to test a tiny "pending changes" UI fix 🙄)

EDIT: Well, reverting didn't help. I'll undo the reverts and wait for backups to be properly fixed. 😊

@jankeromnes jankeromnes marked this pull request as ready for review July 29, 2021 12:33
@gtsiolis
Copy link
Contributor

gtsiolis commented Jul 29, 2021 •
edited by werft-gitpod-dev-com bot
Loading

Looking at this now! 👀

gtsiolis
gtsiolis approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flawless!

5hz7vi

@roboquat roboquat added the lgtm label Jul 29, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8d7eef69c688d5d1399b765ce377663eb10cc175

@roboquat roboquat removed the approved label Jul 29, 2021
@gtsiolis
Copy link
Contributor

/unhold

@gtsiolis
Copy link
Contributor

gtsiolis commented Jul 29, 2021 •
edited by werft-gitpod-dev-com bot
Loading

@jankeromnes could you also approve this, see relevant comment. 🙏

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Jul 29, 2021 •
edited
Loading

Flawless!

Thanks a lot for the review @gtsiolis! 🙌

@jankeromnes could you also approve this, see relevant comment. 🙏

Er, what 😂

spiderman-meme

/approve

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gtsiolis, jankeromnes

Associated issue: #4670

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 4c70e7a into main Jul 29, 2021
@roboquat roboquat deleted the jx/realign-pending-changes branch July 29, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsiolis gtsiolis gtsiolis approved these changes

Assignees

@gtsiolis gtsiolis

Labels
approved component: dashboard size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pending changes link is misaligned on the workspaces list
4 participants
@jankeromnes @csweichel @gtsiolis @roboquat