[dashboard] redirect users to www when logged out #4070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankeromnes
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
Code looks good and works as advertised! Thanks @AlexTugarev and @svenefftinge. 👍
Two small suggestions in-line, otherwise good to merge.
We want to redirect not logged in users from the root URL with no additional context provided to the website. fixes #3898
svenefftinge
force-pushed
the
se/www-redirect
branch
from
7ab2b5d
to
5105a52
Compare
|
/werft run 👍 started the job as gitpod-build-se-www-redirect.2 |
|
/werft run 👍 started the job as gitpod-build-se-www-redirect.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to redirect not logged in users from the root URL with no additional context provided to the website.
fixes #3898
how to test: