[installer] Support enabling protected secrets #13484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: delivery
|
Currently it changes the rendering of the installer config when no flag is specified to |
|
Not intentional, but also not harmful I think. I will change it anyway, both to keep it consistent and to fix the test failure. |
Furisto
force-pushed
the
cw/enable-ps-sh
branch
from
d86ee00
to
48379a4
Compare
easyCZ
approved these changes
Sep 30, 2022
|
/werft run with-sh-preview 👍 started the job as gitpod-build-cw-enable-ps-sh.2 |
12 tasks
| @@ -119,6 +119,8 @@ type WorkspaceConfig struct { | |||
| // Deprecated | |||
| UsageReportBucketName string `json:"usageReportBucketName"` | |||
| } `json:"contentService"` | |||
|
|
|||
| EnableProtectedSecrets bool `json:"enabledProtectedSecrets"` | |||
There was a problem hiding this comment.
nit: is enabled a typo? Just because in the example you gave in the description it was enable and kinda took me a minute to realize when testing. :)
There was a problem hiding this comment.
Yes, this is a typo. Great catch :)
nandajavarma
approved these changes
Sep 30, 2022
csweichel
force-pushed
the
cw/enable-ps-sh
branch
from
48379a4
to
9b267f9
Compare
|
/unold |
|
/unhold |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for enabling protected secrets in the installer.
How to test
Run the installer with the following config:
and observe how the server configmap now contains a new default feature flag.
Release Notes