Add support for JetBrains EAP IDEs (2022.3) #13400

felladrin · 2022-09-28T09:56:15Z

Description

Now that IDEA/PyCharm/PhpStorm/GoLand latest version is v2022.3 in Gitpod, we can add support for JetBrains IDEs v2022.3.

All code changes were done to accommodate the API differences between v2022.2 and v2022.3. There were no logic/flow changes in the plugin.

The dev server script (launch-dev-server.sh) has been improved to allow us locally test EAP and Stable versions of the IDE, which is a common point of failure during Werft builds - because there we build the plugin for EAP and Stable IDE versions simultaneously.
- By default, running launch-dev-server.sh, will launch the JetBrains EAP version.
- If we want to build launch JetBrains Stable version we run it with the additional 's' parameter: launch-dev-server.sh -s

How to test

1. Access the Preview Environment of this PR
2. Open a workspace using the Stable Version of IntelliJ IDEA and check if the Control Center is being displayed correctly and that the IDE shows no errors about Gitpod Plugin.
3. Do the same as Step 2, but now using the Latest Stable Version of IntelliJ IDEA.

We won't be able to test on preview environments, as the EAP JetBrains IDEs versions are pinned to 2022.2.1 during the Self-Hosted release. So please test it on gitpod.io by following these steps:

Having the Stable IntelliJ IDEA selected as IDE, access https://gitpod.io/#referrer:jetbrains-gateway:intellij/https://github.com/gitpod-io/gitpod/pull/13400
On terminal, run: cd components/ide/jetbrains/backend-plugin/
Then run: ./launch-dev-server.sh -s to launch the Stable Version of IntelliJ IDEA and check if the Control Center is being displayed correctly and that the IDE shows no errors about Gitpod Plugin.
Stop the command above and run rm -rf /workspace/ide-backend
Now run: ./launch-dev-server.sh to launch the Latest Stable Version of IntelliJ IDEA, and do the same checks from Step 3.

Release Notes

Gitpod Plugin was updated to work with the JetBrains IDEs v2022.3 (EAP).

Werft options:

/werft with-local-preview
If enabled this will build install/preview
/werft with-preview
/werft with-large-vm
/werft with-integration-tests=all
Valid options are all, workspace, webapp, ide

andreafalzetti · 2022-09-28T10:37:01Z

...ckend-plugin/src/main/kotlin/io/gitpod/jetbrains/remote/GitpodClientProjectSessionTracker.kt

@@ -141,7 +137,7 @@ class GitpodClientProjectSessionTracker(
                            override fun onNext(ps: Status.PortsStatusResponse) {
                                for (port in ps.portsList) {
                                    // Avoiding undesired notifications
-                                    if (ignorePorts.contains(port.localPort)) {
+                                    if (ignoredPortsForNotificationService.getIgnoredPorts().contains(port.localPort)) {


The ignore ports functionality seems to be overcomplicated now, instead of being 3 lines of code, we have 3 files. Am I missing any benefit from doing so?

We need one version for 2022.2 API [1] and another for 2022.3 [1].

Or we can remove the ignored ports part.

oh, I see - thanks!

andreafalzetti

Tested and works as expected.

I see there is an Update warn message but I am not sure how to see its details (no way to see what needs update 🤔 )

/hold

felladrin · 2022-09-28T16:34:59Z

Werft is failing to create the Preview Environments for this PR, so I added instructions for testing it from the Production environment in the PR Description.

andreafalzetti · 2022-09-28T21:01:38Z

/werft run

👍 started the job as gitpod-build-felladrin-jetbrains-ides-2022.3.7
(with .werft/ from main)

felladrin · 2022-09-29T09:16:15Z

ℹ️ I'm going to rebase this PR on the latest commit from the main branch.

andreafalzetti · 2022-09-29T12:33:43Z

@felladrin if Werft keeps failing, I suggest create a new branch and move the PR to a new one (with new prev env)

felladrin · 2022-09-29T12:56:33Z

Something is wrong with the connection between Gitpod Build and and this Github PR, cause the latest build is working fine:
https://werft.gitpod-dev.com/job/gitpod-build-felladrin-jetbrains-ides-2022.3.12, but in the PR it's taking the result of https://werft.gitpod-dev.com/job/gitpod-build-felladrin-jetbrains-ides-2022.3.10

Note: I've unchecked the /werft with-preview due to the issue of Preview Environments having EAP JetBrains IDEs versions at 2022.2.1 instead of 2022.3. [Internal Discussion]

andreafalzetti · 2022-09-29T13:03:44Z

@felladrin I've followed the manual steps and it works as expected. Using -s I see 2022.2.2 and with latest I see 2022.3

I think you need an admin now to merge this PR given the failed Werft check.

felladrin · 2022-09-29T13:04:29Z

/werft run

👍 started the job as gitpod-build-felladrin-jetbrains-ides-2022.3.13
(with .werft/ from main)
Let me try one more time.

andreafalzetti · 2022-09-29T13:10:23Z

/unhold

roboquat added release-note do-not-merge/work-in-progress size/L labels Sep 28, 2022

felladrin mentioned this pull request Sep 28, 2022

Add support for JetBrains EAP IDEs (v2022.3) #13396

Closed

3 tasks

felladrin self-assigned this Sep 28, 2022

gitpod-io deleted a comment from werft-gitpod-dev-com bot Sep 28, 2022

felladrin added team: IDE editor: jetbrains labels Sep 28, 2022

felladrin mentioned this pull request Sep 28, 2022

[jb] Add support for JetBrains IDEs v2022.3 #13044

Closed

3 tasks

felladrin marked this pull request as ready for review September 28, 2022 10:27

felladrin requested a review from a team September 28, 2022 10:27

roboquat removed the do-not-merge/work-in-progress label Sep 28, 2022

andreafalzetti reviewed Sep 28, 2022

View reviewed changes

gitpod-io deleted a comment from werft-gitpod-dev-com bot Sep 28, 2022

andreafalzetti approved these changes Sep 28, 2022

View reviewed changes

roboquat added the do-not-merge/hold label Sep 28, 2022

This was referenced Sep 29, 2022

[jb] Port Forwarding in v2022.3 #12226

Closed

Update Platform Version from JetBrains Backend Plugin #13404

Closed

Add support for JetBrains EAP IDEs (2022.3) #13417

Closed

Add support for JetBrains EAP IDEs (2022.3)

83d939a

felladrin force-pushed the felladrin/jetbrains-ides-2022.3 branch from d485e9c to 83d939a Compare September 29, 2022 09:16

felladrin mentioned this pull request Sep 29, 2022

Update Platform Version from JetBrains Backend Plugin #13447

Closed

1 task

gitpod-io deleted a comment from werft-gitpod-dev-com bot Sep 29, 2022

roboquat removed the do-not-merge/hold label Sep 29, 2022

roboquat merged commit bdd7951 into main Sep 29, 2022

roboquat deleted the felladrin/jetbrains-ides-2022.3 branch September 29, 2022 13:10

felladrin mentioned this pull request Sep 29, 2022

Add support for JetBrains EAP IDEs (2022.3) #13457

Merged

roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Sep 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for JetBrains EAP IDEs (2022.3) #13400

Add support for JetBrains EAP IDEs (2022.3) #13400

felladrin commented Sep 28, 2022 •

edited

Loading

andreafalzetti Sep 28, 2022

felladrin Sep 28, 2022 •

edited

Loading

andreafalzetti Sep 28, 2022 •

edited

Loading

andreafalzetti left a comment

felladrin commented Sep 28, 2022 •

edited

Loading

andreafalzetti commented Sep 28, 2022 •

edited by werft-gitpod-dev-com bot

Loading

felladrin commented Sep 29, 2022 •

edited

Loading

andreafalzetti commented Sep 29, 2022

felladrin commented Sep 29, 2022

andreafalzetti commented Sep 29, 2022

felladrin commented Sep 29, 2022 •

edited by werft-gitpod-dev-com bot

Loading

andreafalzetti commented Sep 29, 2022

Add support for JetBrains EAP IDEs (2022.3) #13400

Add support for JetBrains EAP IDEs (2022.3) #13400

Conversation

felladrin commented Sep 28, 2022 • edited Loading

Description

How to test

Release Notes

Werft options:

andreafalzetti Sep 28, 2022

Choose a reason for hiding this comment

felladrin Sep 28, 2022 • edited Loading

Choose a reason for hiding this comment

andreafalzetti Sep 28, 2022 • edited Loading

Choose a reason for hiding this comment

andreafalzetti left a comment

Choose a reason for hiding this comment

felladrin commented Sep 28, 2022 • edited Loading

andreafalzetti commented Sep 28, 2022 • edited by werft-gitpod-dev-com bot Loading

felladrin commented Sep 29, 2022 • edited Loading

andreafalzetti commented Sep 29, 2022

felladrin commented Sep 29, 2022

andreafalzetti commented Sep 29, 2022

felladrin commented Sep 29, 2022 • edited by werft-gitpod-dev-com bot Loading

andreafalzetti commented Sep 29, 2022

felladrin commented Sep 28, 2022 •

edited

Loading

felladrin Sep 28, 2022 •

edited

Loading

andreafalzetti Sep 28, 2022 •

edited

Loading

felladrin commented Sep 28, 2022 •

edited

Loading

andreafalzetti commented Sep 28, 2022 •

edited by werft-gitpod-dev-com bot

Loading

felladrin commented Sep 29, 2022 •

edited

Loading

felladrin commented Sep 29, 2022 •

edited by werft-gitpod-dev-com bot

Loading