Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[installer]: only allow config patch if advanced mode enabled #13272

Merged
merged 1 commit into from
Sep 26, 2022
Merged

[installer]: only allow config patch if advanced mode enabled #13272

merged 1 commit into from
Sep 26, 2022

Conversation

mrsimonemms
Copy link
Contributor

Description

Spotted a regression in the Installer refactoring where a config patch could be applied if advanced mode isn't enabled. This fixes it.

Release Notes

[installer]: only allow config patch if advanced mode enabled

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@mrsimonemms mrsimonemms marked this pull request as ready for review September 25, 2022 20:28
@mrsimonemms mrsimonemms requested a review from a team September 25, 2022 20:28
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Sep 25, 2022
Pothulapati
Pothulapati approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@Pothulapati Pothulapati left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and good find!

Holding on the nit, but feel free to move forward if you think so!
/hold

install/installer/pkg/config/v1/envvars.go Outdated Show resolved Hide resolved
@roboquat roboquat added size/M and removed size/S labels Sep 26, 2022
Pothulapati
Pothulapati approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mrsimonemms
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 3be23aa into main Sep 26, 2022
@roboquat roboquat deleted the sje/kots-config-patch branch September 26, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pothulapati Pothulapati Pothulapati approved these changes

Assignees
No one assigned
Labels
release-note size/M team: delivery Issue belongs to the self-hosted team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrsimonemms @Pothulapati @roboquat