Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add new test TestPrebuildAndRegularWorkspaceDifferentWorkspaceClass #13268

Merged
merged 2 commits into from
Sep 28, 2022
Merged

test: add new test TestPrebuildAndRegularWorkspaceDifferentWorkspaceClass #13268

merged 2 commits into from
Sep 28, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Sep 25, 2022 •
edited by atduarte
Loading

Description

Add a new test to test prebuild and regular workspace with different workspace class

  • Prebuild small workspace class (20Gi) + regular large workspace class (30Gi): the workspace can start
  • Prebuild large workspace class (30Gi) + regular small workspace class (20Gi): the workspace can't start because the restore volume snapshot size > the PVC size

Related Issue(s)

Partially #12638

How to test

cd test

go test  -run ^TestPrebuildAndRegularWorkspaceDifferentWorkspaceClass$ github.com/gitpod-io/gitpod/test/tests/components/ws-manager -count=1 -namespace=default -kubeconfig=/home/gitpod/.kube/config -v

Release Notes

Show an error if the workspace's persistent volume is smaller than the restore volume snapshot

Documentation

None

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide

@jenting jenting requested a review from a team September 25, 2022 15:27
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Sep 25, 2022
@jenting jenting mentioned this pull request Sep 25, 2022
Closed
6 tasks
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jenting-12638-case4.7 because the annotations in the pull request description changed
(with .werft/ from main)

@jenting jenting changed the title test: add TestPrebuildSmallAndUserLargeWorkspaceClass and TestPrebuildLargeAndUserSmallWorkspaceClass test: add new test TestPrebuildAndRegularWorkspaceDifferentWorkspaceClass Sep 27, 2022
@jenting jenting force-pushed the jenting/12638-case4 branch 2 times, most recently from ea2919d to 80bf4b5 Compare September 28, 2022 02:30
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jenting-12638-case4.11 because the annotations in the pull request description changed
(with .werft/ from main)

@jenting jenting force-pushed the jenting/12638-case4 branch 3 times, most recently from eb6240d to 58e4b49 Compare September 28, 2022 02:35
@jenting jenting marked this pull request as ready for review September 28, 2022 02:39
@jenting
ws-manager: return error if restore volume snapshot to smaller PVC size
98f5813 
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting
Copy link
Contributor Author

jenting commented Sep 28, 2022

/hold
wait for CI pass

@jenting
test: add new test TestPrebuildAndRegularWorkspaceDifferentWorkspaceC…
bd64c99 
…lass

Test prebuild and regular workspace with different workspace class

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting
Copy link
Contributor Author

jenting commented Sep 28, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jenting-12638-case4.17
(with .werft/ from main)

@jenting
Copy link
Contributor Author

jenting commented Sep 28, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-large-vm

👍 started the job as gitpod-build-jenting-12638-case4.18
(with .werft/ from main)

@utam0k
Copy link
Contributor

utam0k commented Sep 28, 2022

This PR includes testing, but isn't the main focus of this PR a change to ws-manager? Since I think this PR provides value to users, why don't you write a Release Note?

utam0k
utam0k reviewed Sep 28, 2022
View reviewed changes
test/tests/components/ws-manager/prebuild_test.go
// TODO: do not use hard-code workspace class name to prevent if we change to different environment to run the test
PrebuildWorkspaceClass: "default",
RegularWorkspaceClass: "small",
//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intended to add this line to know which parts are the TODO.

@jenting jenting requested a review from utam0k September 28, 2022 07:29
@jenting
Copy link
Contributor Author

jenting commented Sep 28, 2022

This PR includes testing, but isn't the main focus of this PR a change to ws-manager? Since I think this PR provides value to users, why don't you write a Release Note?

Release note added.

@jenting
Copy link
Contributor Author

jenting commented Sep 28, 2022

/hold

/unhold

@roboquat roboquat merged commit 129f9b4 into main Sep 28, 2022
@roboquat roboquat deleted the jenting/12638-case4 branch September 28, 2022 07:42
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utam0k utam0k utam0k approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/XL team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenting @utam0k @roboquat