Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jb] respect GW user settings (proxies, certificates) #10974

Merged
merged 1 commit into from
Jun 29, 2022
Merged

[jb] respect GW user settings (proxies, certificates) #10974

merged 1 commit into from
Jun 29, 2022

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Jun 28, 2022 •
edited
Loading

Description

Respect user settings (proxies, certificates) of JetBrains Gateway while connecting to Gitpod API.

Related Issue(s)

fix #10694

How to test

Test for regressions:

  • download a version of JB Gateway plugin from JB Marketplace [1]
  • install it manually following this instruction [2]
    • make sure to click apply and restart IDE
  • check whether that you still can see list of workspaces on gitpod.io
  • start a workspace in preview envs with IntelliJ and check that it can connect as well

A customer already confirmed that changes working in regards of respecting settings. [1]

Release Notes

Respect user settings (proxies, certificates) of JetBrains Gateway while connecting to Gitpod API.

Documentation

Werft options:

  • /werft with-preview

@akosyakov
Copy link
Member Author

akosyakov commented Jun 29, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-ak-gw-settings.3
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-ak-gw-settings.2 because the annotations in the pull request description changed
(with .werft/ from main)

@akosyakov akosyakov marked this pull request as ready for review June 29, 2022 06:56
@akosyakov akosyakov requested a review from a team June 29, 2022 06:56
@akosyakov akosyakov requested a review from felladrin June 29, 2022 06:56
felladrin
felladrin approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great! ✅

Here are some screenshots taken during tests:

image

image

image

image

I've also noticed the implementation affected only these files:

  • GitpodConnectionService.kt
  • GatewayGitpodClient.kt
  • GitpodServerLauncher.java

The other files affected were just reformatted (blank lines at the end of the file and removal of the semi-colons).

@roboquat roboquat merged commit bd5d3ea into main Jun 29, 2022
@roboquat roboquat deleted the ak/gw_settings branch June 29, 2022 08:51
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jun 30, 2022
@mustard-mh mustard-mh mentioned this pull request Jul 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felladrin felladrin felladrin approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note size/L team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[jb] GW plugin should respect GW configs (proxy, certificates, etc.)
3 participants
@akosyakov @felladrin @roboquat