Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in github request caching #7307

Closed
MatthewFagan opened this issue Dec 20, 2021 · 0 comments · Fixed by #8793
Closed

Bugs in github request caching #7307

MatthewFagan opened this issue Dec 20, 2021 · 0 comments · Fixed by #8793
Assignees
Labels
team: webapp Issue belongs to the WebApp team type: bug Something isn't working

Comments

@MatthewFagan
Copy link

Bug description

In the file components/server/src/github/api.ts, lines 244, 250, 264, 273, and 288, the cache key is defined as ${params.owner}/${params.owner} instead of ${params.owner}/${params.repo}. This causes the caching of these requests to fail

Fix: Change ${params.owner}/${params.owner} to ${params.owner}/${params.repo}

Steps to reproduce

Go to /workspaces page and hit F5. All the cached results squash each other and caching fails for all requests.

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

No response

@sagor999 sagor999 added the team: webapp Issue belongs to the WebApp team label Feb 26, 2022
@geropl geropl added the type: bug Something isn't working label Mar 14, 2022
@geropl geropl self-assigned this Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: webapp Issue belongs to the WebApp team type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants