Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pre-commit hooks #1627

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

adam-moss
Copy link
Contributor

Description:

Migrates the pre-commit hooks to the new syntax.

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes?
  • Have you lint your code locally prior to submission?

@@ -1,16 +1,16 @@
- id: gitleaks
name: Detect hardcoded secrets
description: Detect hardcoded secrets using Gitleaks
entry: gitleaks protect --verbose --redact --staged
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adam-moss thanks for the PR. I believe the --verbose and --redact flags should be present still.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add them for explicitness if you prefer, but --redact would be the same as --redact=100 which is the default I think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated @zricethezav

Signed-off-by: Adam Moss <2951486+adam-moss@users.noreply.github.com>
@adam-moss adam-moss force-pushed the refactor/pre-commit branch from dbfaf96 to fdf9dfd Compare November 5, 2024 18:00
@zricethezav zricethezav merged commit 48a2e0e into gitleaks:master Nov 5, 2024
1 check passed
rgmz pushed a commit to rgmz/gitleaks that referenced this pull request Dec 5, 2024
Signed-off-by: Adam Moss <2951486+adam-moss@users.noreply.github.com>
rgmz pushed a commit to rgmz/gitleaks that referenced this pull request Dec 5, 2024
Signed-off-by: Adam Moss <2951486+adam-moss@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants