-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nasal programming language extension. #5134
Conversation
I think we're going to need
Where did you get the sample from? We need the URL to that source in this section of the template. Normally peeps want support for a language so they can have syntax highlighting on GitHub. How about adding https://github.com/RenanMsV/nasal-vscode to this PR? I'm guessing this is for the same language and seems to do a good job highlighting the sample you've included as can be seen here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment at #5134 (comment)
I have updated the post. But I am unsure how to update the heuristic. |
Sorry about the delay in getting back to this. From a quick look at Nasal and Assembly, I think we might be OK with leaving it to the classifier as the two appear to be quite distinct from each other. So the next steps would be to:
All of this would happen in this PR. If all goes well, all the tests should pass without any thing else, but we'll see 🤞. |
I've finished off this PR. I got the colour from the Nasal logo at https://wiki.flightgear.org/Nasal_Console The only thing I've not done is add a syntax highlighting grammar as I've just noticed that the one I referenced before is licensed under the GPL which we can't use. |
Description
Add extension for Nasal language.
And yes, its used for hundreds of github repos.
Checklist: