Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nasal programming language extension. #5134

Merged
merged 10 commits into from
Jun 28, 2022

Conversation

NikolaiVChr
Copy link
Contributor

@NikolaiVChr NikolaiVChr commented Jan 9, 2021

Description

Add extension for Nasal language.
And yes, its used for hundreds of github repos.

Checklist:

@NikolaiVChr NikolaiVChr requested a review from a team as a code owner January 9, 2021 16:42
@lildude lildude requested a review from Alhadis January 22, 2021 17:16
@lildude
Copy link
Member

lildude commented Jan 25, 2021

I think we're going to need .nas added to another language and a heuristic as .nas appears to be quite popular and they don't all appear to be Nasal. From a quick look, quite a few appear to be Assembly.

I have included a real-world usage sample for all extensions added in this PR:

  • Sample source(s): samples/Nasal/damage.nas

    • [URL to each sample source, if applicable]

Where did you get the sample from? We need the URL to that source in this section of the template.

Normally peeps want support for a language so they can have syntax highlighting on GitHub. How about adding https://github.com/RenanMsV/nasal-vscode to this PR? I'm guessing this is for the same language and seems to do a good job highlighting the sample you've included as can be seen here

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment at #5134 (comment)

@NikolaiVChr
Copy link
Contributor Author

I have updated the post.

But I am unsure how to update the heuristic.

@lildude
Copy link
Member

lildude commented Jul 19, 2021

But I am unsure how to update the heuristic.

Sorry about the delay in getting back to this.

From a quick look at Nasal and Assembly, I think we might be OK with leaving it to the classifier as the two appear to be quite distinct from each other.

So the next steps would be to:

  1. Add .nas to the list of extensions for "Assembly"
  2. Add two representative real-world samples of Assembly .nas files
  3. Add another real-world representative sample of Nasal

All of this would happen in this PR.

If all goes well, all the tests should pass without any thing else, but we'll see 🤞.

@lildude
Copy link
Member

lildude commented Jun 27, 2022

I've finished off this PR. I got the colour from the Nasal logo at https://wiki.flightgear.org/Nasal_Console

The only thing I've not done is add a syntax highlighting grammar as I've just noticed that the one I referenced before is licensed under the GPL which we can't use.

@lildude lildude merged commit e1a4148 into github-linguist:master Jun 28, 2022
@BobDotCom BobDotCom mentioned this pull request May 8, 2023
1 task
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants