Force encoding of posix_spawn output #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 for fixing this. A test might be nice though? |
|
@jacobvosmaer I'll add one in the evening :) Done :) |
|
👍 thanks! |
bkeepers
added a commit
that referenced
this pull request
Sep 11, 2014
Force encoding of posix_spawn output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the encoding of the output of
POSIX::Spawn::Child.new(*command, :input => target)in https://github.com/github/markup/blob/master/lib/github/markup/command_implementation.rb#L36 is alwaysASCII-8Bit although the input encoding might be different (e.g.UTF-8`).This PR forces the encoding of the output of the call to be the same as the input data.
/cc @jacobvosmaer