-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds POD6, the markup language for Perl6, to the repo #1173
Conversation
Closes github#907 when accepted (along with the rest of the commits).
Any update on this? |
Now that github-linguist/linguist#4083 has been merged, can we have a go at this one? |
No response from any maintainer here yet? I wonder if there's a way to get some more attention to this from them, since we're waiting for over two months to get feedback here. |
Not really. It will probably have to be redone, if the new version of linguist is out... |
As detailed at github-linguist/linguist#4083 (comment), I've had to revert the addition of Pod 6 support to Linguist as we can't roll it out to GitHub.com until markup has support to render Pod 6 files. A Linguist and markup release with support for Pod 6 will need to be made around about the same time (possibly even the same PR) to ensure users aren't left scratching their heads wondering why one pod file suddenly renders correctly and another doesn't (because it's now being detected as Pod 6 instead of Pod). github-linguist/linguist#4149 is the new Linguist PR that adds back Pod 6 support and remains dependant on a similar markup PR, whether that be this one or another. |
So what do you want me to do here? |
Nothing is needed from you right now. Someone from one of the teams at GitHub responsible for markup will need to assess the two Pod 6 PRs, select the best and advise further. |
OK. Just tell me who to send the fruit basket to help my cause :-) |
Ping? |
or | ||
|
||
``` | ||
bundle install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe do this change as a separate PR? There's already another one with some README additions that this might be combined with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which one do you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was thinking of this one: https://github.com/github/markup/pull/1174/files
Co-Authored-By: JJ <jjmerelo@gmail.com>
One other thought, maybe it would be good to provide a fallback to https://metacpan.org/pod/distribution/Perl6-Pod/scripts/pod6xhtml, presuming that its output is acceptable? It's admittedly a little wacky to use Perl 5 to render Perl 6 docs, but on the other hand deploying a CPAN module to a server that already runs Perl 5 might be an easier sell for some folks' (read: likely mine) sysadmins than deploying Perl 6 to a thing that previously did not have it. |
Merged master, resolved PR review comments, added a The language detect test fails because Linguist can't recognise pod6 yet. |
@jordemort This seems like a good idea, but The problem of getting Perl 6 deployed is still very real; I'll look into it. |
If it helps, there's a |
I'll make a new markup release now that this is working with the latest Linguist release, but there's still work left on our end to get Rakudo in the right places. (We're actively working on it, but there are lots of places where it needs to end up and the process is not simple.) |
Thanks!
|
Pod6 is a new, and more modern version of Perl's POD.
Some additional changes to documentation and auxiliary files. Refs also Raku/doc#167, which I will happily close when this is accepted and released.