Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Nwjs #2265

Closed
wants to merge 1 commit into from
Closed

Create Nwjs #2265

wants to merge 1 commit into from

Conversation

joshplant
Copy link

Reasons for making this change:
This is becoming a hugely popular project, and I've benefited from this .gitignore many times. Nwjs is a cross-platform application framework using Chromium to display web-apps, and Node.js for back-end processing. Similar to Phonegap/Apache Cordova but for Windows/Linux/Mac desktops.

Links to documentation supporting these rule changes:
https://nwjs.io/

Link to application or project’s homepage:
https://github.com/nwjs/nw.js

@shiftkey
Copy link
Member

Links to documentation supporting these rule changes:
https://nwjs.io/

This link doesn't include any resources about the rules specified. I skimmed the main site and some of the builder projects to see if they also had any guidance but their .gitignore files were very different to this.

Could you please provide more information?

@joshplant
Copy link
Author

The gitignore included in the project reference pre-build files, this gitignore references the final nwjs executables. Many developers do not want to include the nwjs executables, since these are often downloaded to the client in the installer, similar to a redistributable library.

The files being referenced here are included in the downloads on the nwjs website.

joeblau added a commit to toptal/gitignore.io that referenced this pull request Mar 25, 2017
Fixes github/gitignore#2333 - Add Advanced Installer gitignore #2333
Fixes github/gitignore#2317 - Add A-Frame template #2317
Fixes github/gitignore#2327 - Added Salesforce .gitIgnore #2327
Fixes github/gitignore#2323 - Add new gitignore for CMS 1C-Bitrix.gitignore #2323
Fixes github/gitignore#2326 - Add new gitignore for Ansible test driven development #2326
Fixes github/gitignore#2311 - Add PAWN.gitignore #2311
Fixes github/gitignore#2309 - Add Crystal template #2309
Fixes github/gitignore#2308 - .gitignore for OpenFrameworks.cc #2308
Fixes github/gitignore#2303 - Add clean gitignore #2303
Fixes github/gitignore#2294 - Add ATS.gitignore #2294
Fixes github/gitignore#2283 - Create jboss-6.x #2283
Fixes github/gitignore#2131 - Create Snapcraft.gitignore #2131
Fixes github/gitignore#2086 - Add gitignore for Cypress Semiconductor IDE #2086
Fixes github/gitignore#2089 - Add Racket.gitignore #2089
Fixes github/gitignore#2103 - Android studio gitignore #2103
Fixes github/gitignore#2116 - Added Kentico.gitignore #2116
Fixes github/gitignore#2124 - Add Ceylon. #2124
Fixes github/gitignore#2127 - Add Buck gitignore values #2127
Fixes github/gitignore#2142 - Add Altium Designer gitignore file #2142
Fixes github/gitignore#2153 - A new template for Perl 6 #2153
Fixes github/gitignore#2160 - Add initial gitignore with bin exclusion for particle IoT platform. #2160
Fixes github/gitignore#2167 - Create IAR.gitignore #2167
Fixes github/gitignore#2171 - Added JMeter gitignore #2171
Fixes github/gitignore#2188 - Create Y86.gitignore #2188
Fixes github/gitignore#2218 - PureBasic #2218
Fixes github/gitignore#2230 - Create MikroC.gitignore #2230
Fixes github/gitignore#2265 - Create Nwjs #2265
Fixes github/gitignore#2272 - Added gitignore for the Python-based Nikola Static Site Generator #2272
Fixes github/gitignore#2279 - gitignore for jboss-4.2.3.GA #2279
Fixes github/gitignore#2274 - A new template gitignore for QtCreator like IDE for pure C/C++ projs #2274
Fixes github/gitignore#2014 - Added MavensMate.gitignore #2014
joeblau added a commit to toptal/gitignore.io that referenced this pull request Mar 25, 2017
* Updated master template list

* Added 25 Tempaltes from https://github.com/github/gitignore

Fixes github/gitignore#2333 - Add Advanced Installer gitignore #2333
Fixes github/gitignore#2317 - Add A-Frame template #2317
Fixes github/gitignore#2327 - Added Salesforce .gitIgnore #2327
Fixes github/gitignore#2323 - Add new gitignore for CMS 1C-Bitrix.gitignore #2323
Fixes github/gitignore#2326 - Add new gitignore for Ansible test driven development #2326
Fixes github/gitignore#2311 - Add PAWN.gitignore #2311
Fixes github/gitignore#2309 - Add Crystal template #2309
Fixes github/gitignore#2308 - .gitignore for OpenFrameworks.cc #2308
Fixes github/gitignore#2303 - Add clean gitignore #2303
Fixes github/gitignore#2294 - Add ATS.gitignore #2294
Fixes github/gitignore#2283 - Create jboss-6.x #2283
Fixes github/gitignore#2131 - Create Snapcraft.gitignore #2131
Fixes github/gitignore#2086 - Add gitignore for Cypress Semiconductor IDE #2086
Fixes github/gitignore#2089 - Add Racket.gitignore #2089
Fixes github/gitignore#2103 - Android studio gitignore #2103
Fixes github/gitignore#2116 - Added Kentico.gitignore #2116
Fixes github/gitignore#2124 - Add Ceylon. #2124
Fixes github/gitignore#2127 - Add Buck gitignore values #2127
Fixes github/gitignore#2142 - Add Altium Designer gitignore file #2142
Fixes github/gitignore#2153 - A new template for Perl 6 #2153
Fixes github/gitignore#2160 - Add initial gitignore with bin exclusion for particle IoT platform. #2160
Fixes github/gitignore#2167 - Create IAR.gitignore #2167
Fixes github/gitignore#2171 - Added JMeter gitignore #2171
Fixes github/gitignore#2188 - Create Y86.gitignore #2188
Fixes github/gitignore#2218 - PureBasic #2218
Fixes github/gitignore#2230 - Create MikroC.gitignore #2230
Fixes github/gitignore#2265 - Create Nwjs #2265
Fixes github/gitignore#2272 - Added gitignore for the Python-based Nikola Static Site Generator #2272
Fixes github/gitignore#2279 - gitignore for jboss-4.2.3.GA #2279
Fixes github/gitignore#2274 - A new template gitignore for QtCreator like IDE for pure C/C++ projs #2274
Fixes github/gitignore#2014 - Added MavensMate.gitignore #2014
@joeblau
Copy link

joeblau commented Mar 25, 2017

@jpl42 - This tempalte is live on gitignore.io - https://www.gitignore.io/api/nwjs

@shiftkey shiftkey self-assigned this Oct 28, 2018
@shiftkey
Copy link
Member

@jpl42 apologies for the delay in replying to this.

I had a lot of these templates requested, but I couldn't quite figure out the right place for them. I ended up settling on #2857, and you'll see a NW.js template can now be found at community/JavaScript/NWjs.gitignore.

Feel free to submit any future improvements to that template, and thanks again for the contribution!

@shiftkey shiftkey closed this Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants