Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an explanation to reduce PHP framework clutter #1424

Merged
merged 1 commit into from
Feb 2, 2017
Merged

Conversation

arcresu
Copy link
Contributor

@arcresu arcresu commented Mar 1, 2015

Several of the templates consist solely of long lists of files which are installed by default by PHP frameworks. These template really aren't all that helpful because they are brittle in that the list of files is specific to a particular version of the software. Having a template for each version seems overkill, and in most cases you would be better off using ls or similar to automatically produce such a gitignore, if that's what you need.

See also #985 for my previous explanation of this problem. If we agree that this is a problem, then I propose to delete the templates which currently follow this pattern. If there is a way to curate a small, useful set of rules about these projects, then people can re-introduce them in new PRs, but the current list of rules seem unsalvageably messy in most cases.

  • Magento
  • Joomla
  • Drupal
  • LemonStand
  • SugarCRM
  • Symfony
  • ZendFramework

@emilv
Copy link

emilv commented Nov 4, 2015

How are they brittle? When new files are introduced you can often just add them too to the .gitignore without damaging old versions of the framework. And it does not seem like a huge burden to keep them updated. I would agree with you for aged, unmaintained .gitignore files, but as long as people are willing to maintain them I do not see a reason to exclude them from here.

We use the Magento .gitignore template all the time even for internal projects.

So I do not agree with this PR. It is an unneccessary restriction. If pollution becomas a problem it is entirely possible to just arrange this repo into subfolders.

@mkutyba mkutyba mentioned this pull request Dec 3, 2015
@shiftkey
Copy link
Member

shiftkey commented Feb 2, 2017

@emilv

When new files are introduced you can often just add them too to the .gitignore without damaging old versions of the framework.

An interesting example of this - Magento v2 came out and is a significant change with Magento v1 - there's three PRs to add a new version, because v2 is incompatible with the layout of v1.

I'm not sure how to go about managing these situations (I'm pushing for contributions for new versions to be incorporated into the one file) but for now I like this guidance at least. I have other suggestions to refine this which I'll PR in due course.

@shiftkey shiftkey merged commit 100943c into master Feb 2, 2017
u9E9F pushed a commit to u9E9F/gitignore that referenced this pull request Jul 8, 2017
Add an explanation to reduce PHP framework clutter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants