Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for actions/setup-node pnpm cache #8389

Merged
merged 4 commits into from
Jul 28, 2021
Merged

Add documentation for actions/setup-node pnpm cache #8389

merged 4 commits into from
Jul 28, 2021

Conversation

jacobwgillespie
Copy link
Contributor

@jacobwgillespie jacobwgillespie commented Jul 20, 2021 •
edited
Loading

Why:

The actions/setup-node action now supports pnpm caching as of v2.3.0, and @MaksimZhukov requested a PR to update the docs for that addition.

What's being changed:

I've added the workflow YAML example from https://github.com/actions/setup-node#caching-packages-dependencies for pnpm underneath the existing npm and yarn examples, matching the order from the action README.

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Jul 20, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 20, 2021
@jacobwgillespie jacobwgillespie mentioned this pull request Jul 20, 2021
Merged
maxim-lobanov
maxim-lobanov previously approved these changes Jul 20, 2021
View reviewed changes
MaksimZhukov
MaksimZhukov previously approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@MaksimZhukov MaksimZhukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you! Nitpick: I think it make sense to mention the pnpm package manager in the Caching dependencies to speed up workflows guide.

@jacobwgillespie
Copy link
Contributor Author

I think it make sense to mention the pnpm package manager in the Caching dependencies to speed up workflows guide.

Added! 👍

MaksimZhukov
MaksimZhukov previously approved these changes Jul 21, 2021
View reviewed changes
@177771

This comment has been minimized.

Sign in to view
@ramyaparimi
Copy link
Contributor

@jacobwgillespie Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jul 21, 2021
skedwards88
skedwards88 reviewed Jul 28, 2021
View reviewed changes
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! I'm going to convert the disclaimer to a reusable, then I'll get this merged down for you.

content/actions/guides/building-and-testing-nodejs.md Outdated Show resolved Hide resolved
@skedwards88 skedwards88 dismissed stale reviews from ghost and MaksimZhukov via 0c4e5b6 July 28, 2021 19:51
@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Jul 28, 2021
@github-actions github-actions bot removed the waiting for review Issue/PR is waiting for a writer's review label Jul 28, 2021
@skedwards88 skedwards88 enabled auto-merge (squash) July 28, 2021 19:52
@skedwards88 skedwards88 merged commit 8704099 into github:main Jul 28, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@jacobwgillespie jacobwgillespie deleted the pnpm-actions-cache branch July 28, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skedwards88 skedwards88 skedwards88 approved these changes

@MaksimZhukov MaksimZhukov MaksimZhukov left review comments

@maxim-lobanov maxim-lobanov maxim-lobanov left review comments

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team ready to merge This pull request is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jacobwgillespie @177771 @ramyaparimi @maxim-lobanov @skedwards88 @MaksimZhukov