Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling fixes for various typos #30890

Merged
merged 50 commits into from
Jan 5, 2024
Merged

Spelling fixes for various typos #30890

merged 50 commits into from
Jan 5, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jan 2, 2024

Why:

Closes: #30889

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

jsoref added 4 commits January 2, 2024 11:35
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref jsoref requested a review from a team as a code owner January 2, 2024 16:51
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 2, 2024
Copy link
Contributor

github-actions bot commented Jan 2, 2024

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:

  • content/code-security/code-scanning/managing-code-scanning-alerts/about-autofix-for-codeql-code-scanning.md
  • content/code-security/secret-scanning/about-the-regular-expression-generator-for-custom-patterns.md

You'll need to revert all of the files you changed that match that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

The complete list of files we can't accept are:

  • .devcontainer/**
  • .github/workflows/**
  • .github/CODEOWNERS
  • assets/fonts/**
  • data/graphql/**
  • data/reusables/rai/**
  • Dockerfile*
  • src/*/scripts/**
  • src/**.json
  • src/workflows/**
  • lib/redirects/**
  • package*.json
  • content/actions/deployment/security-hardening-your-deployments/**

We also can't accept contributions to files in the content directory with frontmatter type: rai.

Copy link
Contributor

github-actions bot commented Jan 2, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/deployment/targeting-different-environments/using-environments-for-deployment.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae
actions/migrating-to-github-actions/automated-migrations/migrating-from-bitbucket-pipelines-with-github-actions-importer.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae
admin/administering-your-instance/administering-your-instance-from-the-command-line/administering-your-instance-using-the-github-cli.md ghes
ghes
admin/administering-your-instance/administering-your-instance-from-the-command-line/command-line-utilities.md ghes@ 3.11 3.10 3.9 3.8 3.7
ghes@ 3.11 3.10 3.9 3.8 3.7
admin/configuration/configuring-private-networking-for-hosted-compute-products/configuring-private-networking-for-github-hosted-runners.md ghec
ghec
admin/identity-and-access-management/provisioning-user-accounts-for-enterprise-managed-users/configuring-scim-provisioning-for-enterprise-managed-users.md ghec
ghec
admin/identity-and-access-management/provisioning-user-accounts-for-enterprise-managed-users/troubleshooting-team-membership-with-identity-provider-groups.md ghec
ghec
admin/managing-accounts-and-repositories/managing-users-in-your-enterprise/suspending-and-unsuspending-users.md ghes@ 3.11 3.10 3.9 3.8 3.7
ghes@ 3.11 3.10 3.9 3.8 3.7
admin/managing-accounts-and-repositories/managing-users-in-your-enterprise/viewing-people-in-your-enterprise.md ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae
admin/monitoring-activity-in-your-enterprise/analyzing-how-your-team-works-with-server-statistics/about-server-statistics.md ghes@ 3.11 3.10 3.9 3.8 3.7
ghes@ 3.11 3.10 3.9 3.8 3.7
admin/monitoring-activity-in-your-enterprise/reviewing-audit-logs-for-your-enterprise/streaming-the-audit-log-for-your-enterprise.md ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
admin/policies/enforcing-policies-for-your-enterprise/enforcing-repository-management-policies-in-your-enterprise.md ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae
apps/creating-github-apps/writing-code-for-a-github-app/building-ci-checks-with-a-github-app.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae
apps/using-github-apps/saml-and-github-apps.md ghec
ghec
billing/managing-billing-for-github-marketplace-apps/upgrading-the-billing-plan-for-a-github-marketplace-app.md fpt
ghec
fpt
ghec
code-security/code-scanning/troubleshooting-sarif-uploads/file-too-large.md fpt
ghec
ghes@ 3.11 3.10 3.9
fpt
ghec
ghes@ 3.11 3.10 3.9
code-security/dependabot/working-with-dependabot/guidance-for-the-configuration-of-private-registries-for-dependabot.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
code-security/getting-started/best-practices-for-preventing-data-leaks-in-your-organization.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
code-security/getting-started/dependabot-quickstart-guide.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
code-security/security-advisories/guidance-on-reporting-and-writing-information-about-vulnerabilities/managing-privately-reported-security-vulnerabilities.md fpt
ghec
fpt
ghec
codespaces/reference/disaster-recovery-for-github-codespaces.md fpt
ghec
fpt
ghec
copilot/github-copilot-chat/using-github-copilot-chat-in-your-ide.md fpt
ghec
fpt
ghec
copilot/github-copilot-enterprise/copilot-chat-in-github/using-github-copilot-chat-in-githubcom.md ghec
ghec
copilot/troubleshooting-github-copilot/troubleshooting-issues-with-github-copilot-chat.md fpt
ghec
fpt
ghec
get-started/writing-on-github/working-with-advanced-formatting/organizing-information-with-collapsed-sections.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae
migrations/overview/programmatically-importing-repositories.md fpt
ghec
fpt
ghec
migrations/using-github-enterprise-importer/migrating-between-github-products/migrating-organizations-from-githubcom-to-github-enterprise-cloud.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
organizations/managing-peoples-access-to-your-organization-with-roles/maintaining-ownership-continuity-for-your-organization.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae
organizations/managing-saml-single-sign-on-for-your-organization/troubleshooting-identity-and-access-management-for-your-organization.md ghec
ghec
rest/authentication/authenticating-to-the-rest-api.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jan 2, 2024
@nguyenalex836
Copy link
Contributor

@jsoref Thanks so much for opening a PR! I'll get this triaged for review ✨

Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsoref, this is much appreciated—I've noted a few requested changes and I'll need to take another look over this after you've made them, and then we can look to get this merged 👍

GitHub changes the Service via Updates and addition of new features. Nothwithstanding the foregoing, GitHub reserves the right at any time to modify or discontinue, temporarily or permanently, the Service (or any part of it) with or without notice.
GitHub changes the Service via Updates and addition of new features. Notwithstanding the foregoing, GitHub reserves the right at any time to modify or discontinue, temporarily or permanently, the Service (or any part of it) with or without notice.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be a pain, but would you mind opening a separate PR for this? It'll be more straightforward to get it reviewed (see https://github.com/github/site-policy/blob/main/CONTRIBUTING.md).

Otherwise, I'm happy to open one myself internally if you prefer.

jsoref added 5 commits January 4, 2024 15:33
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref added 7 commits January 4, 2024 15:34
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref added 22 commits January 4, 2024 15:34
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for raising this one, and for following up on all those fixes! ✨

This looks good now, so I'll go ahead and get this merged 👍

@subatoi subatoi added this pull request to the merge queue Jan 5, 2024
@subatoi subatoi removed the request for review from a team January 5, 2024 09:33
Merged via the queue into github:main with commit d90a746 Jan 5, 2024
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@jsoref jsoref deleted the spelling branch January 5, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spelling fixes for various items
3 participants